Fix casing of file references in csprojs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building these projects on a case-sensitive file system revealed that the file casing is different on disk. Fixed the reference in csprojs to match the name on disk.
|
👍 Good catch |
|
lgtm: 👍 |
AndyGerlicher
added a commit
that referenced
this pull request
Mar 18, 2015
Fix casing of file references in csprojs
|
Awesome! |
AndyGerlicher
pushed a commit
to AndyGerlicher/msbuild
that referenced
this pull request
Feb 17, 2017
sync to latest
rokonec
referenced
this pull request
in rokonec/msbuild
Jan 20, 2021
rokonec
referenced
this pull request
in rokonec/msbuild
May 3, 2021
- fix unit test to verify serialized data
ladipro
added a commit
to ladipro/msbuild
that referenced
this pull request
Jun 28, 2021
JaynieBai
pushed a commit
that referenced
this pull request
Jan 18, 2023
Fixes #6773 Context Supersedes #8213 and #8282 Symlinked files were not embedded into binlog - previous solution was too much focused on symlinks and hence requried nontrivial code to properly distinguish aymlinks with available contnet. Alternate approach - proceed with adding file as soon as it has available content Testing Preexisting unit test is excercising the scenario. Added a case for empty file - that still should not be added.
6 tasks
JanKrivanek
added a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building these projects on a case-sensitive file system revealed that the file casing
is different on disk. Fixed the reference in csprojs to match the name on disk.