Remove opt in for new schema for CombineTargetFrameworkInfoProperties #6928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CombineTargetFrameworkInfoProperties, we had hit an issue in which a TF could be invalid as an XML root. We changed the schema to let us escape it, then opted into the new schema in the SDK. This removes the option to not opt into the new schema. It's hopefully still ok to do this; though it would have been better to get it into 17.0, I don't think anyone other than the SDK is using this, so I don't think it should matter.
Forgind
commented
Oct 8, 2021
…escape-hatch-for-validating-schema
Forgind
commented
Feb 28, 2022
rainersigwald
approved these changes
Feb 28, 2022
Forgind
commented
Feb 28, 2022
| @@ -1905,14 +1905,9 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
| </_AdditionalTargetFrameworkInfoPropertyWithValue> | |||
| </ItemGroup> | |||
|
|
|||
| <PropertyGroup> | |||
| <_UseAttributeForTargetFrameworkInfoPropertyNames Condition="'$(_UseAttributeForTargetFrameworkInfoPropertyNames)' == ''">false</_UseAttributeForTargetFrameworkInfoPropertyNames> | |||
There was a problem hiding this comment.
Also put this in a change wave? I vote no because it's a private property, so anyone abusing it knows they might be broken.
Forgind
added
the
merge-when-branch-open
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
May 20, 2022
…operties (dotnet#6928)" This caused a regression in scenarios using Visual Studio 17.3 previews with `global.json` files pointing to old .NET SDKs. This reverts commit fe4fde9. Conflicts: src/Framework/ChangeWaves.cs src/Tasks/CombineTargetFrameworkInfoProperties.cs
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
May 20, 2022
…operties (dotnet#6928)" This caused a regression in scenarios using Visual Studio 17.3 previews with `global.json` files pointing to old .NET SDKs. This reverts commit fe4fde9. Conflicts: src/Framework/ChangeWaves.cs src/Tasks/CombineTargetFrameworkInfoProperties.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CombineTargetFrameworkInfoProperties, we had hit an issue in which a TF could be invalid as an XML root. We changed the schema to let us escape it, then opted into the new schema in the SDK. This removes the option to not opt into the new schema. It's hopefully still ok to do this; though it would have been better to get it into 17.0, I don't think anyone other than the SDK is using this, so I don't think it should matter.
I didn't really test this, but it looks hard to mess up.
Edit: well, maybe 😛