Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagHelperDiscovery results should flow via LSP method call #10173

Closed
phil-allen-msft opened this issue Mar 27, 2024 · 1 comment
Closed

TagHelperDiscovery results should flow via LSP method call #10173

phil-allen-msft opened this issue Mar 27, 2024 · 1 comment
Assignees
@alexgav
Labels
feature-completion
Milestone
17.12 Preview 1

Comments

@phil-allen-msft
Copy link
Contributor

phil-allen-msft commented Mar 27, 2024 •
edited
Loading

In order to make the system work faster and more consistently, discovered tag helpers/components should flow to the remainder of the Razor system using a call like LSP rather than relying exclusively on file read/write.
@alexgav alexgav mentioned this issue Mar 28, 2024
Merged
@phil-allen-msft phil-allen-msft added this to the 17.11 P1 milestone Mar 28, 2024
@DustinCampbell DustinCampbell mentioned this issue Apr 19, 2024
Merged
DustinCampbell added a commit that referenced this issue Apr 22, 2024
@DustinCampbell
Remove ProjectSnapshotManagerDispatcher from ProjectConfigurationStat…
e278610 
…eSynchronizer (#10283)

This change removes `ProjectSnapshotManagerDispatcher` usage from
`ProjectConfigurationStateSynchronizer` and
`ProjectConfigurationFileChangeDetector`. Ultimately, a lot of this code
will go away once #10173 is the default behavior.

As part of this change, I updated
`ProjectConfigurationStateSynchronizer` to use an
`AsyncBatchingWorkQueue`. In my opinion, this is a huge improvement over
the previous implementation.
@DustinCampbell DustinCampbell mentioned this issue May 1, 2024
Merged
DustinCampbell added a commit that referenced this issue May 6, 2024
@DustinCampbell
Write RazorProjectInfo to temporary file and notify language server v…
0947714 
…ia LSP (#10333)

Related to #10173

This change updates the work to pass `RazorProjectInfo` via LSP to
instead write `RazorProjectInfo` instances to temporary files and pass
the file names via LSP. The files are deleted in the language server
after they are deserialized.
@phil-allen-msft
Copy link
Contributor Author

Work has been done and shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgav alexgav

Labels
feature-completion
Projects
None yet
Milestone
17.12 Preview 1
Development

No branches or pull requests
2 participants
@alexgav @phil-allen-msft