Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Basic.Reference.Assemblies #10343

Closed
jjonescz opened this issue May 3, 2024 · 2 comments · Fixed by #10888
Closed

Switch to Basic.Reference.Assemblies #10343

jjonescz opened this issue May 3, 2024 · 2 comments · Fixed by #10888
Assignees
@jjonescz
Labels
area-compiler Umbrella for all compiler issues area-infrastructure tech-debt test scenario
Milestone
17.11 Planning

Comments

@jjonescz
Copy link
Member

jjonescz commented May 3, 2024

https://www.nuget.org/packages/Basic.Reference.Assemblies.AspNet80

Search for typeof(System.Runtime.AssemblyTargetedPatchBandAttribute).Assembly in the codebase to find the places that should be switched over.
@jjonescz jjonescz added test scenario area-compiler Umbrella for all compiler issues labels May 3, 2024
@jjonescz jjonescz mentioned this issue May 3, 2024
Merged
@chsienki chsienki added this to the 17.11 Planning milestone May 9, 2024
@jjonescz jjonescz mentioned this issue May 28, 2024
Merged
@chsienki
Copy link
Contributor

Fixed via #10416

@jjonescz
Copy link
Member Author

There are more places this could be done: #10416 (comment)

@jjonescz jjonescz reopened this Sep 11, 2024
This was referenced Sep 11, 2024
Merged
Merged
jjonescz added a commit to jjonescz/razor that referenced this issue Oct 10, 2024
@jjonescz
Avoid referencing a test assembly in compilation
f428708 
Related to dotnet#10343.
jjonescz added a commit to jjonescz/razor that referenced this issue Oct 11, 2024
@jjonescz
Avoid referencing a test assembly in compilation
f26566e 
Related to dotnet#10343.
@jjonescz jjonescz mentioned this issue Oct 11, 2024
Merged
jjonescz added a commit that referenced this issue Oct 14, 2024
@jjonescz
Avoid referencing a test assembly in compilation (#11005)
ecb4434 
Related to #10343.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjonescz jjonescz

Labels
area-compiler Umbrella for all compiler issues area-infrastructure tech-debt test scenario
Projects
None yet
Milestone
17.11 Planning
Development

Successfully merging a pull request may close this issue.

Use Basic.Reference.Assemblies in Mvc Extension tests jjonescz/razor
2 participants
@jjonescz @chsienki