Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor & C# Light bulbs in VS - v0.2 #5225

Closed
5 tasks done
NTaylorMullen opened this issue Aug 11, 2020 · 1 comment · Fixed by #2501
Closed
5 tasks done

Razor & C# Light bulbs in VS - v0.2 #5225

NTaylorMullen opened this issue Aug 11, 2020 · 1 comment · Fixed by #2501
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

We've done lots of work to enable light bulbs platform agnostically; however, one piece of the light bulb model relies on the ability to provide code actions and then resolve them. This core piece of plumbing is done differently in VSCode and in VS. In VSCode it's done using commands (that's how we implemented it) and in VS there's an expansion of the code action spec. This issue encompasses wiring up the infrastructure to light up our existing Razor light bulbs and enable the first C# light bulb.


@NTaylorMullen NTaylorMullen changed the title Razor & C# Light bulbs in VS - v0.1 Razor & C# Light bulbs in VS - v0.2 Aug 11, 2020
@TanayParikh
Copy link
Contributor

The C# specific lighbulbs are blocked on No Inline C# Diagnostic, Limited Errors. Currently working on a fix for that. Also, prioritized Disable File Operation Based CodeActions in Liveshare/Codespaces as it was a ship blocker.

Moving this to Preview 4.

TanayParikh referenced this issue Sep 16, 2020
### Summary of the changes

- Support for Fully Qualified Namespace C# Light Bulb
![FullyQualifiedCodeAction](https://user-images.githubusercontent.com/14852843/93262976-f1da7f80-f759-11ea-9877-05e9df2ed88b.gif)

- Support for Add Using C# Light bulb
![AddUsingCodeAction](https://user-images.githubusercontent.com/14852843/93263130-2d754980-f75a-11ea-890d-bfb07516a354.gif)

- Abstraction Layer / Refactoring to create shared light bulb infrastructure between TSLanguageServer + HTMLCSharpLanguageServer.
- This implementation doesn't have support for code actions which require resolving with Roslyn (ex. via `textDocument/codeActionResolve`). Working on an appropriate expansion for this, and will likely require changes in `omnisharp-vscode`.
    - Tracked here: https://github.com/dotnet/aspnetcore/issues/25918
- Some general perf optimizations are possible, but wanted to avoid potential pre-optimizations. Will re-visit if we see issues.
- Testing: TODO assuming no issues with the design.

Fixes: https://github.com/dotnet/aspnetcore/issues/24779
Fixes: https://github.com/dotnet/aspnetcore/issues/18173
Fixes: https://github.com/dotnet/aspnetcore/issues/24778
Fixes: https://github.com/dotnet/aspnetcore/issues/25144
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2020
@ghost ghost unlocked this conversation Oct 9, 2021
@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 9, 2021
@allisonchou allisonchou added this to the 16.8-Preview4 milestone Oct 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants