Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VSCode] Implement C# semantic tokens support #6922

Closed
allisonchou opened this issue Sep 28, 2022 · 1 comment
Closed

[VSCode] Implement C# semantic tokens support #6922

allisonchou opened this issue Sep 28, 2022 · 1 comment
Labels
enhancement Small improvement request vscode
Milestone
Backlog

Comments

@allisonchou
Copy link
Contributor

We don't provide C# tokens in VSCode today, which seems fine since the default experience is already decently powerful. However, we may want to look into implementing support in the future. (I tried, but there seems to be some bug with the execute command - will have to investigate more later.)
@ghost ghost added the untriaged label Sep 28, 2022
@DustinCampbell DustinCampbell added the enhancement Small improvement request label Sep 29, 2022
@DustinCampbell DustinCampbell added this to the Backlog milestone Sep 29, 2022
@ghost ghost removed the untriaged label Sep 29, 2022
dibarbet pushed a commit to dibarbet/vscode-csharp that referenced this issue Jun 8, 2023
@allisonchou
Merged PR 472670: [Razor] Remove C# semantic tokens logic
ecd9ccd 
Pretty sure we can do this - the existing provider essentially does nothing since we don't have C# semantic tokens support in VS Code today (tracked via dotnet/razor#6922). At the moment, C# tokens are exclusively provided by TextMate. This should resolve the errors seen in https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1802613.

Related work items: #1802613
@allisonchou allisonchou mentioned this issue Oct 3, 2023
Closed
@allisonchou
Copy link
Contributor Author

Fixed via #9336

@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Small improvement request vscode
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DustinCampbell @danroth27 @allisonchou