Update semantic tokens service to better support The Future™ #10036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Mar 6, 2024
|
|
||
| namespace Microsoft.AspNetCore.Razor.LanguageServer.Semantic; | ||
|
|
||
| internal class LSPCSharpSemanticTokensProvider(IClientConnection clientConnection, IRazorLoggerFactory loggerFactory) : ICSharpSemanticTokensProvider |
There was a problem hiding this comment.
This is a direct move from the sematic tokens service (and change to use LinePositionSpan). The idea is the OOP will have a different implementation of this service (that doesn't use LSP)
There was a problem hiding this comment.
I'll trust you this and won't be reviewing this file :)
davidwengier
force-pushed
the
SemanticTokensService
branch
from
166c9e1
to
8a5839e
Compare
davidwengier
force-pushed
the
RegressCohost
branch
from
3d36512
to
5d628d4
Compare
davidwengier
force-pushed
the
SemanticTokensService
branch
from
8a5839e
to
e7bf11b
Compare
…act C# functionality to a separate service
davidwengier
force-pushed
the
SemanticTokensService
branch
from
e7bf11b
to
23c1c88
Compare
alexgav
reviewed
Mar 7, 2024
...icrosoft.AspNetCore.Razor.LanguageServer/Semantic/Services/IRazorSemanticTokenInfoService.cs
Show resolved
Hide resolved
alexgav
reviewed
Mar 7, 2024
...icrosoft.AspNetCore.Razor.LanguageServer/Semantic/Services/RazorSemanticTokensInfoService.cs
Show resolved
Hide resolved
alexgav
reviewed
Mar 7, 2024
| @@ -1006,12 +1006,14 @@ private async Task VerifySemanticTokensAsync(string documentText, bool precise, | |||
| options.HtmlVirtualDocumentSuffix == "__virtual.html", | |||
| MockBehavior.Strict); | |||
|
|
|||
| var cSharpSemanticTokensProvider = new LSPCSharpSemanticTokensProvider(_clientConnection.Object, LoggerFactory); | |||
There was a problem hiding this comment.
100%! I was chasing the code fixes for a bunch of these, but I guess I missed a few. Thanks!
ryzngard
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work in cohosting, and hence OOP, its a lot easier with a couple of relatively simple changes to the semantic tokens service:
This PR does both of those things, and also:
This is targeting the "regress cohosting" branch because it turns out this new design is impossible in cohosting right now 🤦♂️
Part of #9519