Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BatchingWorkQueue with AsyncBatchingWorkQueue from Roslyn #10140

Merged
merged 17 commits into from
Mar 26, 2024
Merged

Replace BatchingWorkQueue with AsyncBatchingWorkQueue from Roslyn #10140

merged 17 commits into from
Mar 26, 2024

Commits on Mar 22, 2024

  1. Copy AsyncBatchingWorkQueue from Roslyn 

    Roslyn's `AsyncBatchingWorkQueue` is a battle-hardened utility that provides a robust mechanism to do work in batches without blocking.
    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    530fd6d View commit details
    Browse the repository at this point in the history

  2. Rewrite OpenDocumentGenerator to use AsyncBatchingWorkQueue

    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    52fe75d View commit details
    Browse the repository at this point in the history

  3. Don't use BatchingWorkQueue to control semanticTokens/refresh notific… 

    …ations

`WorkspaceSemanticTokensRefreshNotifier` (previously `WorkspaceSemanticTokensRefreshPublisher`) uses a `BatchingWorkQueue` for debouncing, even though it isn't actually batching work. I've replaced this with much simpler code that just tracks a `Task` generated with `Task.Delay(...)`.
    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    bcb5842 View commit details
    Browse the repository at this point in the history

  4. Rewrite WorkspaceProjectStateChangeDetector to use AsyncBatchingWorkQ… 

    …ueue
    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7b4733d View commit details
    Browse the repository at this point in the history

  5. Add a few AsyncBatchingWorkQueue tests

    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f9f7d17 View commit details
    Browse the repository at this point in the history

  6. Delete old BatchingWorkQueue

    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    536fc08 View commit details
    Browse the repository at this point in the history

  7. Small tweaks to CancellationSeries 

    Remove invalid link from comment and make code style consistent.
    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e710932 View commit details
    Browse the repository at this point in the history

  8. Cache SemanticTokens.RefreshSupport value and check it sooner

    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    286bfc7 View commit details
    Browse the repository at this point in the history

  9. Pass cancellation token to Task.Delay

    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2a3c3c2 View commit details
    Browse the repository at this point in the history

  10. Provide AsyncBatchingWorkQueue mechansim to control deduping

    @DustinCampbell
    DustinCampbell committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b5de994 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Add ImmutableArray<T>.GetMostRecentUniqueItems() helper

    @DustinCampbell
    DustinCampbell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7456e25 View commit details
    Browse the repository at this point in the history

  2. Use GetMostRecentUniqueItems(...) helper and remove mechanism from As… 

    …yncBatchingWorkQueue
    @DustinCampbell
    DustinCampbell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    c5bf6e5 View commit details
    Browse the repository at this point in the history

  3. Clean up ImmutableArrayExtensions

    @DustinCampbell
    DustinCampbell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9296580 View commit details
    Browse the repository at this point in the history

  4. Improve test assertion

    @DustinCampbell
    DustinCampbell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    de084f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Fix indentation

    @DustinCampbell
    DustinCampbell committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    357afee View commit details
    Browse the repository at this point in the history

  2. Remove extra word from comment

    @DustinCampbell
    DustinCampbell committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3667681 View commit details
    Browse the repository at this point in the history

  3. Improve test assertion

    @DustinCampbell
    DustinCampbell committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ab4f568 View commit details
    Browse the repository at this point in the history