Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold C# statement keyword blocks #10496

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

davidwengier
Copy link
Contributor

Fixes #10443

@davidwengier davidwengier requested a review from a team as a code owner June 17, 2024 09:47

namespace Microsoft.AspNetCore.Razor.LanguageServer.Folding;

internal sealed class RazorCSharpStatementKeywordFoldingProvider : AbstractSyntaxNodeFoldingProvider<CSharpCodeBlockSyntax>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not need to be registered somewhere in the LSP server?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the test adds manually. Definitely needs to be added to the lsp composition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG 🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️

I even tested this is VS after writing on the issue that it works in VS regardless of this code.

Thank you!

@davidwengier davidwengier merged commit fcbaa47 into dotnet:main Jun 18, 2024
12 checks passed
@davidwengier davidwengier deleted the FoldIfStatements branch June 18, 2024 01:31
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 18, 2024
@jjonescz jjonescz modified the milestones: Next, 17.11 Preview 3 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot collapse @if blocks in razor files
4 participants