Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out PooledArrayBuilder<T> a bit #10606

Merged
merged 16 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,10 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
{
var compilation = CSharpCompilation.Create("components", references: refs);
return compilation.GetTypesByMetadataName("Microsoft.AspNetCore.Components.Rendering.RenderTreeBuilder")
.Any(static (t, compilation) => t.DeclaredAccessibility == Accessibility.Public &&
t.GetMembers("AddComponentParameter").Any(static m => m.DeclaredAccessibility == Accessibility.Public), compilation);
.Any(static t =>
t.DeclaredAccessibility == Accessibility.Public &&
t.GetMembers("AddComponentParameter")
.Any(static m => m.DeclaredAccessibility == Accessibility.Public));
});

IncrementalValuesProvider<(string, SourceGeneratorRazorCodeDocument)> processed(bool designTime)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the MIT license. See License.txt in the project root for license information.

using System.Collections.Generic;
using System;
using Microsoft.AspNetCore.Razor.PooledObjects;
using Xunit;
using SR = Microsoft.AspNetCore.Razor.Utilities.Shared.Resources.SR;

namespace Microsoft.AspNetCore.Razor.Utilities.Shared.Test.PooledObjects;

Expand Down Expand Up @@ -33,20 +34,24 @@ public void AddElements([CombinatorialRange(0, 8)] int count)
}
}

public static IEnumerable<object[]> RemoveAtIndex_Data
public static TheoryData<int, int> RemoveAtIndex_Data
{
get
{
var data = new TheoryData<int, int>();

for (var count = 0; count < 8; count++)
{
for (var removeIndex = 0; removeIndex < 8; removeIndex++)
{
if (removeIndex < count)
{
yield return new object[] { count, removeIndex };
data.Add(count, removeIndex);
}
}
}

return data;
}
}

Expand Down Expand Up @@ -80,4 +85,172 @@ public void RemoveAtIndex(int count, int removeIndex)
}
}
}

private static Func<int, bool> IsEven => x => x % 2 == 0;
private static Func<int, bool> IsOdd => x => x % 2 != 0;

[Fact]
public void Any()
{
using var builder = new PooledArrayBuilder<int>();

Assert.False(builder.Any());

builder.Add(19);

Assert.True(builder.Any());

builder.Add(23);

Assert.True(builder.Any(IsOdd));

// ... but no even numbers
Assert.False(builder.Any(IsEven));
}

[Fact]
public void All()
{
using var builder = new PooledArrayBuilder<int>();

Assert.True(builder.All(IsEven));

builder.Add(19);

Assert.False(builder.All(IsEven));

builder.Add(23);

Assert.True(builder.All(IsOdd));

builder.Add(42);

Assert.False(builder.All(IsOdd));
}

[Fact]
public void FirstAndLast()
{
using var builder = new PooledArrayBuilder<int>();

var exception1 = Assert.Throws<InvalidOperationException>(() => builder.First());
Assert.Equal(SR.Contains_no_elements, exception1.Message);

Assert.Equal(default, builder.FirstOrDefault());

var exception2 = Assert.Throws<InvalidOperationException>(() => builder.Last());
Assert.Equal(SR.Contains_no_elements, exception1.Message);

Assert.Equal(default, builder.LastOrDefault());

builder.Add(19);

Assert.Equal(19, builder.First());
Assert.Equal(19, builder.FirstOrDefault());
Assert.Equal(19, builder.Last());
Assert.Equal(19, builder.LastOrDefault());

builder.Add(23);

Assert.Equal(19, builder.First());
Assert.Equal(19, builder.FirstOrDefault());
Assert.Equal(23, builder.Last());
Assert.Equal(23, builder.LastOrDefault());
}

[Fact]
public void FirstAndLastWithPredicate()
{
using var builder = new PooledArrayBuilder<int>();

var exception1 = Assert.Throws<InvalidOperationException>(() => builder.First(IsOdd));
Assert.Equal(SR.Contains_no_matching_elements, exception1.Message);

Assert.Equal(default, builder.FirstOrDefault(IsOdd));

var exception2 = Assert.Throws<InvalidOperationException>(() => builder.Last(IsOdd));
Assert.Equal(SR.Contains_no_matching_elements, exception2.Message);

Assert.Equal(default, builder.LastOrDefault(IsOdd));

builder.Add(19);

Assert.Equal(19, builder.First(IsOdd));
Assert.Equal(19, builder.FirstOrDefault(IsOdd));
Assert.Equal(19, builder.Last(IsOdd));
Assert.Equal(19, builder.LastOrDefault(IsOdd));

builder.Add(23);

Assert.Equal(19, builder.First(IsOdd));
Assert.Equal(19, builder.FirstOrDefault(IsOdd));
Assert.Equal(23, builder.Last(IsOdd));
Assert.Equal(23, builder.LastOrDefault(IsOdd));

var exception3 = Assert.Throws<InvalidOperationException>(() => builder.First(IsEven));
Assert.Equal(SR.Contains_no_matching_elements, exception3.Message);

Assert.Equal(default, builder.FirstOrDefault(IsEven));

var exception4 = Assert.Throws<InvalidOperationException>(() => builder.Last(IsEven));
Assert.Equal(SR.Contains_no_matching_elements, exception4.Message);

Assert.Equal(default, builder.LastOrDefault(IsEven));

builder.Add(42);

Assert.Equal(42, builder.First(IsEven));
Assert.Equal(42, builder.FirstOrDefault(IsEven));
Assert.Equal(42, builder.Last(IsEven));
Assert.Equal(42, builder.LastOrDefault(IsEven));
}

[Fact]
public void Single()
{
using var builder = new PooledArrayBuilder<int>();

var exception1 = Assert.Throws<InvalidOperationException>(() => builder.Single());
Assert.Equal(SR.Contains_no_elements, exception1.Message);
Assert.Equal(default, builder.SingleOrDefault());

builder.Add(19);

Assert.Equal(19, builder.Single());
Assert.Equal(19, builder.SingleOrDefault());

builder.Add(23);

var exception2 = Assert.Throws<InvalidOperationException>(() => builder.Single());
Assert.Equal(SR.Contains_more_than_one_element, exception2.Message);
var exception3 = Assert.Throws<InvalidOperationException>(() => builder.SingleOrDefault());
Assert.Equal(SR.Contains_more_than_one_element, exception2.Message);
}

[Fact]
public void SingleWithPredicate()
{
using var builder = new PooledArrayBuilder<int>();

var exception1 = Assert.Throws<InvalidOperationException>(() => builder.Single(IsOdd));
Assert.Equal(SR.Contains_no_matching_elements, exception1.Message);
Assert.Equal(default, builder.SingleOrDefault(IsOdd));

builder.Add(19);

Assert.Equal(19, builder.Single(IsOdd));
Assert.Equal(19, builder.SingleOrDefault(IsOdd));

builder.Add(23);

var exception2 = Assert.Throws<InvalidOperationException>(() => builder.Single(IsOdd));
Assert.Equal(SR.Contains_more_than_one_matching_element, exception2.Message);
var exception3 = Assert.Throws<InvalidOperationException>(() => builder.SingleOrDefault(IsOdd));
Assert.Equal(SR.Contains_more_than_one_matching_element, exception2.Message);

builder.Add(42);

Assert.Equal(42, builder.Single(IsEven));
Assert.Equal(42, builder.SingleOrDefault(IsEven));
}
}
Loading