Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unified settings #10607

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix unified settings #10607

merged 1 commit into from
Jul 10, 2024

Conversation

ryzngard
Copy link
Contributor

While self-hosting I noticed unified settings were no longer available and were defaulting back to the classic experience. Looks like they updated how some of the registration works and added a fix for f5 debugging them. Worked locally on my machine but I will not claim any expertise here.

@ryzngard ryzngard requested a review from a team as a code owner July 10, 2024 20:45
[$RootKey$\SettingsManifests\{13b72f58-279e-49e0-a56d-296be02f0805}]
@="Microsoft.VisualStudio.RazorExtension.RazorPackage"
"ManifestPath"="$PackageFolder$\UnifiedSettings\razor.registration.json"
"CacheTag"=qword:5DE8496A8900B809
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wiki said this is updated on f5 scenarios, but I don't know if it still needs to be updated every time we change anything.

"CacheTag": qword - A 64-bit integer value used to indicate changes to the content of the Settings Manifest

The first time a given Manifest Path is discovered, the manifest is parsed and the contents cached. The value of the cache tag is recorded. On subsequent runs of VS the value of "CacheTag" is compared to the one recorded. If the values do not match, then the associated entries in the cache are invalidated, and the manifest is re-processed.

When using the recommended 'ProvideSettingsManifest` attribute, this value is updated on every build using the long ticks of DateTime.Now.

I suggest testing for future people reading this just in case it needs to be manually updated

@ryzngard ryzngard merged commit f8893e8 into dotnet:main Jul 10, 2024
12 checks passed
@ryzngard ryzngard deleted the fix_unified_settings branch July 10, 2024 21:59
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 10, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 Preview 1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants