Roslyn Tokenizer Infrastructure #10676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
commented
Jul 26, 2024
There was a problem hiding this comment.
These tests are duplicates of the non-legacy versions, they just use the legacy parser.
333fred
commented
Jul 26, 2024
| @@ -44,6 +44,10 @@ public partial class RazorSourceGenerator | |||
|
|
|||
| var razorConfiguration = new RazorConfiguration(razorLanguageVersion, configurationName ?? "default", Extensions: [], UseConsolidatedMvcViews: true); | |||
|
|
|||
| // We use the new tokenizer by default | |||
| var useRazorTokenizer = !parseOptions.Features.TryGetValue("use-razor-tokenizer", out var useRazorTokenizerValue) | |||
There was a problem hiding this comment.
I'm not sure the best way to actually test this. We could wait for the new tokenizer and test a side effect, like strings being handled better, but that doesn't seem like a great approach. I don't have any better ideas though.
jjonescz
approved these changes
Jul 29, 2024
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Legacy/LegacyCSharpTokenizer.cs
Outdated
Show resolved
Hide resolved
...osoft.CodeAnalysis.Razor.Compiler/src/Language/Legacy/RoslynCSharpLanguageCharacteristics.cs
Show resolved
Hide resolved
chsienki
approved these changes
Jul 29, 2024
...r/Microsoft.AspNetCore.Razor.Language/legacyTest/Legacy/ImplicitExpressionEditHandlerTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some of the infrastructure that will be needed to get the Roslyn tokenizer in. We'll have the new tokenizer, and an option to switch back to the legacy tokenizer. To make reviewing easier, I would highly suggest going commit-by-commit, to make sure that the renames show up as actual renames.