Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing comma in PublishData #10685

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix trailing comma in PublishData #10685

merged 1 commit into from
Jul 30, 2024

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Jul 30, 2024

Official build containing this change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2505642&view=results

Recent official builds are failing since snap: https://dev.azure.com/dnceng/internal/_build/results?buildId=2505159&view=logs&j=7ae71e7c-d4fe-51ea-64cd-240849b77ab1&t=4f9c0653-2f18-500e-227d-19e80298b3dc

No PublishData found for branch 'main'. Using PublishData for branch 'main' with draft PR status.
The property 'insertionCreateDraftPR' cannot be found on this object. Verify that the property exists and can be set.
At D:\a\_work\_temp\548307e3-ff7c-45ff-9ccc-be3ab4e0bf53.ps1:12 char:3
+   $branchData.insertionCreateDraftPR = 'true'

The failure doesn't really make sense to me. Inspecting the diff from #10681, the most likely thing I can blame is the trailing comma is messing up parsing of the PublishData file.

Consider force merging for expediency @phil-allen-msft.

@RikkiGibson RikkiGibson requested review from a team as code owners July 30, 2024 17:24
@RikkiGibson RikkiGibson merged commit 88b3813 into main Jul 30, 2024
12 checks passed
@RikkiGibson RikkiGibson deleted the RikkiGibson-patch-1 branch July 30, 2024 18:25
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 30, 2024
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants