Don't add already known documents to the misc files project #10753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
reviewed
Aug 16, 2024
Comment on lines
164
to
173
| var potentialProjects = _projectManager.FindPotentialProjects(textDocumentPath); | ||
| foreach (var project in potentialProjects) | ||
| { | ||
| if (project.DocumentFilePaths.Contains(textDocumentPath, FilePathComparer.Instance)) | ||
| { | ||
| // Already in a known project, so we don't want it in the misc files project | ||
| _logger.LogDebug($"File {textDocumentPath} is already in {project.Key} so we're not adding it to the miscellaneous files project"); | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
Isn't this basically the same as the below?
Suggested change
| var potentialProjects = _projectManager.FindPotentialProjects(textDocumentPath); | |
| foreach (var project in potentialProjects) | |
| { | |
| if (project.DocumentFilePaths.Contains(textDocumentPath, FilePathComparer.Instance)) | |
| { | |
| // Already in a known project, so we don't want it in the misc files project | |
| _logger.LogDebug($"File {textDocumentPath} is already in {project.Key} so we're not adding it to the miscellaneous files project"); | |
| return; | |
| } | |
| } | |
| if (_projectManager.TryResolveDocumentInAnyProject(textDocumentPath, _logger, out var project) | |
| { | |
| // Already in a known project, so we don't want it in the misc files project | |
| _logger.LogDebug($"File {textDocumentPath} is already in {project.Key} so we're not adding it to the miscellaneous files project"); | |
| return; | |
| } |
There was a problem hiding this comment.
lol, it very well could be. That's a little embarassing :D
ryzngard
approved these changes
Aug 16, 2024
maryamariyan
approved these changes
Aug 18, 2024
This isn't quite correct. We don't share a project manager across VS and the LSP server, but we do share project information. |
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in the logs that we were double-compiling files, and it was causing issues in my "self versioned documents" branch. Separated out of that to make it easier to review.
RCA is because we now share a project manager across VS and LSP server, so we get real project information much sooner than before, which beats file watchers etc.