Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support component rename from an end tag #10762

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

davidwengier
Copy link
Contributor

Fixes #10717

@davidwengier davidwengier requested a review from a team as a code owner August 19, 2024 05:35
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View this files changes with whitespace diff off

@@ -288,6 +273,43 @@ private static async Task<ImmutableArray<TagHelperDescriptor>> GetOriginTagHelpe
return [primaryTagHelper, associatedTagHelper];
}

private static bool TryGetTagHelperBinding(RazorSyntaxNode owner, int absoluteIndex, [NotNullWhen(true)] out TagHelperBinding? binding)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@davidwengier davidwengier merged commit e165821 into dotnet:main Aug 20, 2024
12 checks passed
@davidwengier davidwengier deleted the RenameFromEndTag branch August 20, 2024 00:29
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 20, 2024
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming a component doesn't work from the end tag
4 participants