Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohost Go To Implementation #10824

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Cohost Go To Implementation #10824

merged 6 commits into from
Sep 6, 2024

Conversation

davidwengier
Copy link
Contributor

Needs dotnet/roslyn#74978
Fixes #10695
Part of #9519

Pretty straightforward. A tiny bit of code moved to be shared with Go To Def, but that's it.

@davidwengier davidwengier requested a review from a team as a code owner September 3, 2024 06:24
@davidwengier davidwengier mentioned this pull request Sep 3, 2024
Open
DustinCampbell
DustinCampbell approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks solid to me. This is definitely good to go in once the Roslyn dependencies are updated and CI passes.

src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/RazorDocumentServiceBase.cs Show resolved Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/RazorDocumentServiceBase.cs Show resolved Hide resolved
...soft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostGoToImplementationEndpointTest.cs Outdated Show resolved Hide resolved
@davidwengier davidwengier requested a review from a team as a code owner September 6, 2024 01:53
@davidwengier
Fix build
f7681c2
@davidwengier
Fix test
70f110d 
This should have been fixed with dotnet#10807 but without the Roslyn bump I guess I didn't realise. Oops!
@davidwengier davidwengier merged commit 49e727b into dotnet:main Sep 6, 2024
12 checks passed
@davidwengier davidwengier deleted the CohostGoToImplementation branch September 6, 2024 03:24
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 6, 2024
This was referenced Sep 10, 2024
Closed
Closed
Closed
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.12 P3 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.12 P3
Development

Successfully merging this pull request may close these issues.

Port Go To Implementation to cohosting
4 participants
@davidwengier @DustinCampbell @ryzngard @phil-allen-msft