Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw if we get an old/bad Inlay Hint request #10968

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Don't throw if we get an old/bad Inlay Hint request #10968

merged 1 commit into from
Oct 4, 2024

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier requested a review from a team as a code owner October 4, 2024 04:35
@davidwengier davidwengier changed the title Don't throw if we get an old/bad request Don't throw if we get an old/bad Inlay Hint request Oct 4, 2024
alexgav
alexgav requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

alexgav
alexgav approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alexgav
Copy link
Contributor

alexgav commented Oct 4, 2024

🕐

Wasn't requesting changes, accidentally clicked the wrong button :)

@davidwengier davidwengier merged commit 9f19fa8 into dotnet:main Oct 4, 2024
12 checks passed
@davidwengier davidwengier deleted the InlayHintBadRange branch October 4, 2024 21:54
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 4, 2024
This was referenced Oct 9, 2024
Closed
Closed
Closed
Closed
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.13 P1 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgav alexgav alexgav approved these changes

@ryzngard ryzngard ryzngard approved these changes

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwengier @alexgav @DustinCampbell @ryzngard @phil-allen-msft