Emit and map empty csharp tokens #10969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test and update baselines
|
@dotnet/razor-compiler for review please. |
ryzngard
approved these changes
Oct 4, 2024
jjonescz
approved these changes
Oct 7, 2024
| @@ -35,7 +35,7 @@ protected override void PrepareProjectForFirstOpen(string projectFileName) | |||
| base.PrepareProjectForFirstOpen(projectFileName); | |||
| } | |||
|
|
|||
| [IdeFact(Skip = "https://github.com/dotnet/razor/issues/10965")] // Completion is broken in FUSE for sole `@` characters | |||
| [IdeFact] | |||
| public async Task Completion_DateTime() | |||
There was a problem hiding this comment.
Integration tests don't run automatically on PRs, right? Should we enqueue a run manually to verify this test?
There was a problem hiding this comment.
Ran integration tests on this PR and everything looks good.
...Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentCodeGenerationTestBase.cs
Outdated
Show resolved
Hide resolved
|
@333fred or @DustinCampbell for a second compiler review. Thanks! |
DustinCampbell
approved these changes
Oct 8, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10965