Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Cleanup For ExtractToComponent #11008

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Some Cleanup For ExtractToComponent #11008

merged 6 commits into from
Oct 15, 2024

Commits on Oct 11, 2024

  1. Clean up some of the extract to component code. Move more work to the 

    resolver, use pooled objects where applicable, and try to make the
provider cleaner when creating the ExtractToComponentCodeActionParams
    @ryzngard
    ryzngard committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    364f581 View commit details
    Browse the repository at this point in the history

  2. Remvoe unused variables

    @ryzngard
    ryzngard committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d36d175 View commit details
    Browse the repository at this point in the history

  3. Add a few more selection tests and extract logic

    @ryzngard
    ryzngard committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    07ad6ed View commit details
    Browse the repository at this point in the history

  4. Remove unused parameter

    @ryzngard
    ryzngard committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bf4f97b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Cleanup the cleanup branch

    @ryzngard
    ryzngard committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8e4867b View commit details
    Browse the repository at this point in the history

  2. Update tests

    @ryzngard
    ryzngard committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f793e95 View commit details
    Browse the repository at this point in the history