Move RootNamespace from HostProject to RazorConfiguration #11109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should probably have been in the previous PR
DustinCampbell
approved these changes
Oct 29, 2024
....Razor.ProjectEngineHost/Serialization/MessagePack/Formatters/RazorConfigurationFormatter.cs
Outdated
Show resolved
Hide resolved
....Razor.ProjectEngineHost/Serialization/MessagePack/Formatters/RazorConfigurationFormatter.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/RazorProjectInfoFactory.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectState.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectState.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/RemoteProjectSnapshot.cs
Show resolved
Hide resolved
jjonescz
reviewed
Oct 30, 2024
| @@ -16,7 +16,8 @@ public sealed record class RazorConfiguration( | |||
| bool SuppressAddComponentParameter = false, | |||
| LanguageServerFlags? LanguageServerFlags = null, | |||
| bool UseRoslynTokenizer = false, | |||
| LanguageVersion CSharpLanguageVersion = LanguageVersion.Default) | |||
| LanguageVersion CSharpLanguageVersion = LanguageVersion.Default, | |||
| string? RootNamespace = null) | |||
There was a problem hiding this comment.
Looks like this isn't referenced anywhere from the compiler layer; why does it need to be in the compiler's RazorConfiguration?
There was a problem hiding this comment.
RazorConfiguration serves double duty right now, as the thing that the compiler reads some things from, and the type that stores all of the compiler configuration knobs that are serialized between the IDE host and the LSP server. There has been much discussion about removing the configure lambdas for configuring the compiler, and moving to fully utilise the RazorConfiguration, so this is something of a hedge towards that.
jjonescz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11092
Nerd sniped myself I guess.