Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle skipped trivia in the C# tokenizer #11207

Merged
merged 6 commits into from
Nov 16, 2024
Merged

Conversation

333fred
Copy link
Member

@333fred 333fred commented Nov 13, 2024

Reaction to dotnet/roslyn#75724. Will need to update to a version of Roslyn with this change to be able to test.

Reaction to dotnet/roslyn#75724. Will need to update to a version of Roslyn with this change to be able to test.
@333fred 333fred requested a review from jjonescz November 14, 2024 18:53
@333fred 333fred marked this pull request as ready for review November 14, 2024 20:05
@333fred 333fred requested review from a team as code owners November 14, 2024 20:05
@333fred 333fred requested a review from jjonescz November 14, 2024 20:05
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tooling

@333fred 333fred merged commit 4d7ed74 into dotnet:main Nov 16, 2024
12 checks passed
@333fred 333fred deleted the skipped-trivia branch November 16, 2024 16:35
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 16, 2024
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants