[Fuse] bind-Value:attribute support #11214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
reviewed
Nov 14, 2024
|
|
@dotnet/razor-compiler for review please :) |
jjonescz
approved these changes
Nov 15, 2024
|
@333fred or @DustinCampbell for a second review. Thanks! |
DustinCampbell
approved these changes
Nov 18, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various
@bind-Value:get@bind-Value:set,@bind-Value:eventtag helpers are mostly macro based, meaning that what they expand into isn't represented in the document.For the IDE to enable Hover, FAR etc on the
Valuepart of the attribute, we need to emit something that we can map (we can't map the same piece of text twice).This PR takes the approach of emitting a simple discard expression of the
nameofthe referenced value so we have something to map for the IDE, but is completely elided by the compiler at build time, so has no runtime effect.We already had the machinery to correctly emit the
nameofincluding on generic types, so this PR just re-uses that.Fixes: #10966