Publish generated HTML in the client #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
changed the title
ajaybhargavb
force-pushed
the
ajbaaska/only-html
branch
from
0752010 to
ab0705f
Compare
ajaybhargavb
changed the title
NTaylorMullen
suggested changes
Feb 27, 2020
There was a problem hiding this comment.
Holy cow, this is incredible! 👏
One thing we should do in addition to what you have here is add an HTML completion functional test that excercises one of the broken cases of the past.
i.e.
@{
if (1 < 2) { }
}
<|If I recall correctly completion at the | doesn't work in the currently released bits because the HTML document sees the 1 < 2 and is expecting a start/end tag. Could also use a C# comment that mentions an HTML comment start to replicate the issue too.
src/Razor/src/Microsoft.AspNetCore.Razor.Language/RazorCodeDocumentExtensions.cs
Show resolved
Hide resolved
...azor/src/Microsoft.AspNetCore.Razor.LanguageServer/DefaultGeneratedDocumentContainerStore.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DefaultGeneratedDocumentPublisher.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DefaultGeneratedDocumentPublisher.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DefaultGeneratedDocumentPublisher.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.VSCode/src/Html/HtmlProjectedDocument.ts
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.VSCode/src/RazorDocumentManager.ts
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.VSCode/src/RazorDocumentManager.ts
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DocumentState.cs
Show resolved
Hide resolved
...st/Microsoft.CodeAnalysis.Razor.Workspaces.Test/ProjectSystem/DefaultDocumentSnapshotTest.cs
Show resolved
Hide resolved
|
🆙 📅 |
NTaylorMullen
approved these changes
Feb 27, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
May 17, 2020
* Publish generated HTML in the client * feedback * fix \n\nCommit migrated from dotnet/razor@a666c6f
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
* Publish generated HTML in the client * feedback * fix \n\nCommit migrated from dotnet/razor@a666c6f Commit migrated from dotnet/aspnetcore@d41276b0fae6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#14286
updateHtmlBuffercommand to update the buffer on the clientRazorDocumentManagerandHtmlDocumenton the client side to follow the same behavior of CSharp for updating the virtual background documentUnsyncronizedDocumentProcessedListenerwhere we were updating the background C# document with all razor content