Enhance support for configuring debuggers used for Blazor WASM apps #2774
Conversation
captainsafia
requested review from
ajaybhargavb,
NTaylorMullen,
ryanbrandenburg and
TanayParikh
as code owners
src/Razor/src/Microsoft.AspNetCore.Razor.VSCode.Extension/package.json
Outdated
Show resolved
Hide resolved
| }, | ||
| "browserConfig": { | ||
| "description": "Options based", | ||
| "type": "object" |
There was a problem hiding this comment.
Is it just an object because it's a generic key=>value dictionary with no structure?
There was a problem hiding this comment.
It does have a structure. It should only contain the properties that you would pass to the JS debugger (or .NET debugger in the case above). I'll add docs to clarify this.
We could copy/paste the entire config setup for the .NET/JS debuggers here but that didn't seem sustainable.
There was a problem hiding this comment.
I feel like you'll probably get some push back on this only because users will be "off on their own" to setup these configuration options. VSCode users typically rely heavily on IntelliSense to configure things like this
There was a problem hiding this comment.
Hmmmmm. Good point. I'll strike a balance by including the options that users are more likely to use here.
...or/src/Microsoft.AspNetCore.Razor.VSCode/src/BlazorDebug/BlazorDebugConfigurationProvider.ts
Show resolved
Hide resolved
...or/src/Microsoft.AspNetCore.Razor.VSCode/src/BlazorDebug/BlazorDebugConfigurationProvider.ts
Show resolved
Hide resolved
| @@ -114,6 +89,7 @@ export class BlazorDebugConfigurationProvider implements vscode.DebugConfigurati | |||
| inspectUri: '{wsProtocol}://{url.hostname}:{url.port}/_framework/debug/ws-proxy?browser={browserInspectUri}', | |||
| trace: configuration.trace || false, | |||
| noDebug: configuration.noDebug || false, | |||
| ...configuration.browserConfig, | |||
There was a problem hiding this comment.
Do we need a separate category of #PranavPoints for Typescript?
...or/src/Microsoft.AspNetCore.Razor.VSCode/src/BlazorDebug/BlazorDebugConfigurationProvider.ts
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.VSCode/src/BlazorDebug/TerminateDebugHandler.ts
Show resolved
Hide resolved
Summary of the changes
Fixes: dotnet/aspnetcore#27518, dotnet/vscode-csharp#4161, dotnet/vscode-csharp#4108