Port @bind:after support to 17.5 / 7.0.200 releases #8304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Feb 21, 2023
chsienki
changed the title
Due to the way we decided to implement bind get,set,after, customers can run into situations where their components render many more times than expected, which results in confusion and performance degradation. This was due to the fact that we chose to rely on EventCallback to implement this feature and we did not realize there were some side effects associated with it. The APIs we are adding bypass the whole EventCallback infrastructure (simplifying the implementation too) and fix the issue. This change updates the compiler to rely on the new runtime APIs (cherry picked from commit 9ce52f1afbfb819fc8499a590385200b97b13f33)
1 task
jaredpar
changed the title
jaredpar
approved these changes
Feb 27, 2023
1 task
ghost
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Update Razor addin version to 17.5 * Include Compiler features in Project Engine * Skip Diagnostic tests for now * [Blazor] Bind after changes (#363) (#8304) Due to the way we decided to implement bind get,set,after, customers can run into situations where their components render many more times than expected, which results in confusion and performance degradation. This was due to the fact that we chose to rely on EventCallback to implement this feature and we did not realize there were some side effects associated with it. The APIs we are adding bypass the whole EventCallback infrastructure (simplifying the implementation too) and fix the issue. This change updates the compiler to rely on the new runtime APIs (cherry picked from commit 9ce52f1afbfb819fc8499a590385200b97b13f33) Co-authored-by: Javier Calvarro Nelson <[email protected]> * [17.5] Visit assemblies in search for view components (#8328) * Add a test * Visit assemblies in search for view components --------- Co-authored-by: Allison Chou <[email protected]> Co-authored-by: Shen Chen <[email protected]> Co-authored-by: Sandy Armstrong <[email protected]> Co-authored-by: David Wengier <[email protected]> Co-authored-by: Ryan Brandenburg <[email protected]> Co-authored-by: Chris Sienkiewicz <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Jan Jones <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Update Razor addin version to 17.5 * Include Compiler features in Project Engine * Skip Diagnostic tests for now * [Blazor] Bind after changes (#363) (#8304) Due to the way we decided to implement bind get,set,after, customers can run into situations where their components render many more times than expected, which results in confusion and performance degradation. This was due to the fact that we chose to rely on EventCallback to implement this feature and we did not realize there were some side effects associated with it. The APIs we are adding bypass the whole EventCallback infrastructure (simplifying the implementation too) and fix the issue. This change updates the compiler to rely on the new runtime APIs (cherry picked from commit 9ce52f1afbfb819fc8499a590385200b97b13f33) Co-authored-by: Javier Calvarro Nelson <[email protected]> * [17.5] Visit assemblies in search for view components (#8328) * Add a test * Visit assemblies in search for view components --------- Co-authored-by: Allison Chou <[email protected]> Co-authored-by: Shen Chen <[email protected]> Co-authored-by: Sandy Armstrong <[email protected]> Co-authored-by: David Wengier <[email protected]> Co-authored-by: Ryan Brandenburg <[email protected]> Co-authored-by: Chris Sienkiewicz <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Jan Jones <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Update Razor addin version to 17.5 * Include Compiler features in Project Engine * Skip Diagnostic tests for now * [Blazor] Bind after changes (#363) (#8304) Due to the way we decided to implement bind get,set,after, customers can run into situations where their components render many more times than expected, which results in confusion and performance degradation. This was due to the fact that we chose to rely on EventCallback to implement this feature and we did not realize there were some side effects associated with it. The APIs we are adding bypass the whole EventCallback infrastructure (simplifying the implementation too) and fix the issue. This change updates the compiler to rely on the new runtime APIs (cherry picked from commit 9ce52f1afbfb819fc8499a590385200b97b13f33) Co-authored-by: Javier Calvarro Nelson <[email protected]> * [17.5] Visit assemblies in search for view components (#8328) * Add a test * Visit assemblies in search for view components --------- Co-authored-by: Allison Chou <[email protected]> Co-authored-by: Shen Chen <[email protected]> Co-authored-by: Sandy Armstrong <[email protected]> Co-authored-by: David Wengier <[email protected]> Co-authored-by: Ryan Brandenburg <[email protected]> Co-authored-by: Chris Sienkiewicz <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Jan Jones <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Update Razor addin version to 17.5 * Include Compiler features in Project Engine * Skip Diagnostic tests for now * [Blazor] Bind after changes (#363) (#8304) Due to the way we decided to implement bind get,set,after, customers can run into situations where their components render many more times than expected, which results in confusion and performance degradation. This was due to the fact that we chose to rely on EventCallback to implement this feature and we did not realize there were some side effects associated with it. The APIs we are adding bypass the whole EventCallback infrastructure (simplifying the implementation too) and fix the issue. This change updates the compiler to rely on the new runtime APIs (cherry picked from commit 9ce52f1afbfb819fc8499a590385200b97b13f33) Co-authored-by: Javier Calvarro Nelson <[email protected]> * [17.5] Visit assemblies in search for view components (#8328) * Add a test * Visit assemblies in search for view components --------- Co-authored-by: Allison Chou <[email protected]> Co-authored-by: Shen Chen <[email protected]> Co-authored-by: Sandy Armstrong <[email protected]> Co-authored-by: David Wengier <[email protected]> Co-authored-by: Ryan Brandenburg <[email protected]> Co-authored-by: Chris Sienkiewicz <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Jan Jones <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Update Razor addin version to 17.5 * Include Compiler features in Project Engine * Skip Diagnostic tests for now * [Blazor] Bind after changes (#363) (#8304) Due to the way we decided to implement bind get,set,after, customers can run into situations where their components render many more times than expected, which results in confusion and performance degradation. This was due to the fact that we chose to rely on EventCallback to implement this feature and we did not realize there were some side effects associated with it. The APIs we are adding bypass the whole EventCallback infrastructure (simplifying the implementation too) and fix the issue. This change updates the compiler to rely on the new runtime APIs (cherry picked from commit 9ce52f1afbfb819fc8499a590385200b97b13f33) Co-authored-by: Javier Calvarro Nelson <[email protected]> * [17.5] Visit assemblies in search for view components (#8328) * Add a test * Visit assemblies in search for view components --------- Co-authored-by: Allison Chou <[email protected]> Co-authored-by: Shen Chen <[email protected]> Co-authored-by: Sandy Armstrong <[email protected]> Co-authored-by: David Wengier <[email protected]> Co-authored-by: Ryan Brandenburg <[email protected]> Co-authored-by: Chris Sienkiewicz <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Jan Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of 9ce52f1afbfb819fc8499a590385200b97b13f33 which fixes the
bind:get,bind:set,bind:afterissues.