Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include all component declarations when creating descriptors #8614

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Include all component declarations when creating descriptors #8614

merged 3 commits into from
Apr 24, 2023

Conversation

jjonescz
Copy link
Member

Fixes #8610.

@jjonescz jjonescz marked this pull request as ready for review April 19, 2023 15:00
@jjonescz jjonescz requested a review from a team as a code owner April 19, 2023 15:00
@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Apr 19, 2023
@jjonescz
Copy link
Member Author

jjonescz commented Apr 20, 2023 •
edited
Loading

@chsienki @dotnet/razor-compiler - this PR fixes a regression that blocks aspnetcore from updating SDK, PTAL.

@JamesNK
Copy link
Member

JamesNK commented Apr 21, 2023 •
edited
Loading

@chsienki @dotnet/razor-compiler - Please prioritize. SDK update has been blocked for a long time, and this is the current failure.

@mitchdenny mitchdenny mentioned this pull request Apr 21, 2023
Merged
@mitchdenny
Copy link
Member

Is this ready to go?

@davidwengier
Copy link
Member

@mitchdenny The policy is that it needs two approvals from members of the compiler team.

@sebastienros
Copy link
Member

@dotnet/razor-compiler can you please take a quick look? The PR seems easy enough and it's currently blocking an important SDK ingestion in aspnetcore.

chsienki
chsienki approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets take this to unblock the SDK insertion, but we should follow up with a run of the generator benchmarks to understand the impact on performance.

@chsienki chsienki merged commit 4686a7c into dotnet:main Apr 24, 2023
@sebastienros
Copy link
Member

Thanks @chsienki

@jjonescz jjonescz deleted the 8610-GlobalPrefixing branch April 24, 2023 18:46
@jjonescz jjonescz mentioned this pull request Apr 25, 2023
Closed
@allisonchou allisonchou mentioned this pull request Apr 27, 2023
Closed
This was referenced May 17, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generator incorrectly prefixes relative namespaced types with global::
6 participants
@jjonescz @JamesNK @mitchdenny @davidwengier @sebastienros @chsienki