Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick #8913 #8951

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Cherry Pick #8913 #8951

merged 1 commit into from
Jul 13, 2023

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Jul 12, 2023 •
edited
Loading

@ryzngard
Remove unsupported feature (dotnet#8913)
3c0b894 
we don't support commands in our markdown documentation for completion, so just remove it entirely

Tested in a cshtml and .razor file:

CSharp completion
HTML completion (links to MDN still work)
Razor completion
@ryzngard ryzngard requested a review from a team as a code owner July 12, 2023 23:11
@ryzngard ryzngard enabled auto-merge July 12, 2023 23:43
@ryzngard ryzngard merged commit 8ab9f87 into dotnet:release/omnisharp-vscode Jul 13, 2023
@ryzngard ryzngard deleted the cp/8913 branch July 13, 2023 21:05
@allisonchou allisonchou mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonchou allisonchou allisonchou approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryzngard @davidwengier @allisonchou