Merge main to release/dev17.8 #9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1-bf1bd43ce104
Add support for tag helper checksums
Honour the locale name sent through via the parameters to the Initialize LSP method
Allow documents to have multiple virtual documents of a single virtual document type
… version Co-authored-by: David Wengier <[email protected]>
…801.3 (#9074) Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23381.1 -> To Version 8.0.0-beta.23401.3 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23374.1 -> To Version 1.0.0-beta.23381.1 (parent: Microsoft.DotNet.Arcade.Sdk Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This change refactors the various tag helper resolvers to prefer composition over inheritance and use an `ITagHelperResolver` as the base type.
As usual, the Html formatter is doing the right thing here, and our C# adjustments then break things. Essentially it sees `@bind` as a Razor directive, so wants it at column 0. This change simply makes the `@` on an attribute pretend to be Html, so the C# formatter leaves it alone.
Merge release/dev17.8 to main
…825.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23422.1 -> To Version 8.0.0-beta.23425.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23418.1 -> To Version 1.0.0-beta.23423.1 (parent: Microsoft.DotNet.Arcade.Sdk
Rework BoundAttributeDescriptionInfo to avoid failures due to unexpected inputs
…5-fc109157ea74 [main] Update dependencies from dotnet/arcade
Clean up public surface area
Fix completion in self closing tags inside C#
Defend against bad input in the Inferred mapping
Fix hover when Roslyn gives us a range that can't be mapped
Fix formatting of `@bind` attributes
Integration Tests
dibarbet
added
the
auto-merge
|
Hello @dibarbet! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dibarbet
changed the title
davidwengier
approved these changes
Aug 28, 2023
ghost
merged commit 
|
Looks like this was squash-merged which probably shouldn't have been. I guess that causes the merge conflicts in #9188. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes: