Call Roslyn to format new code behind documents #9263
Conversation
The node used to create the ExtractStart property actually starts at the end of the directive, on the line before the opening brace.
This is a silly test, but strictly speaking its correct, as our logic is to take whatever Roslyn gives us. There are tests on the Roslyn side to validate that they format the document correctly etc.
| .GetDocumentIntermediateNode() | ||
| .FindDescendantNodes<UsingDirectiveIntermediateNode>(); |
| // Sadly we can't use a "real" workspace here, because we don't have access. If we use our workspace, it wouldn't have the right settings | ||
| // for C# formatting, only Razor formatting, and we have no access to Roslyn's real workspace, since it could be in another process. |
There was a problem hiding this comment.
Oh, this is weird. Thanks for adding the comment to explain. However, if we just pass an instance of AdhocWorkspace, I imagine that it's only ever going to get a default set of C# formatting options and will ignore anything the user might have set in VS Options or .editorconfig. Do you know what we need trom Roslyn to call into formatting without a workspace? I seem to remember that @CyrusNajmabadi was working on some sort of mechanism (SolutionServices?).
There was a problem hiding this comment.
Firstly, worth mentioning this path is now just a fallback until the Roslyn changes are inserted. Once that is in I wouldn't expect the above call to return null.
Do you know what we need trom Roslyn to call into formatting without a workspace?
The Format method takes a SyntaxFormattingOptions, which you can see in the "real" call here: https://github.com/dotnet/roslyn/pull/69878/files#diff-7ab7cb7fc8b5d3ba31e8bbbdcd96a9dfcadc129bde4258aa73a91ab4b4720bfbR82
In theory we could call Roslyn to get that info, but if we're going to call Roslyn then the call on line 221 would have worked and we don't need this anyway :)
ghost
added this to the 
Fixes #4330
Fixes #8766
Includes #9262 so just review from 8a2b8af onwards
Goes with dotnet/roslyn#69878 and dotnet/vscode-csharp#6329
I logged #9264 to follow up with a better test, though strictly speaking the one I've added id exhaustive :)
Behaviour of Extract to Code Behind before this change. Note the many using statements and block scoped namespace.
Behaviour after this change. Note the file scoped namespace, and file header.
The squiggle on
NavigationManageris due to an.editorconfigrule I have on in that project, requiringthis.qualification, so is unrelated.