Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flag to disable the Razor LSP, leaving only cohosting #9767

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Add feature flag to disable the Razor LSP, leaving only cohosting #9767

merged 2 commits into from
Dec 27, 2023

Conversation

davidwengier
Copy link
Contributor

If nothing else, this cleans up the logs when trying to work out why your cohost endpoint isn't working :)

@davidwengier davidwengier requested a review from a team as a code owner December 27, 2023 08:33
alexgav
alexgav approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit ed7eb9b into features/cohost Dec 27, 2023
12 checks passed
@davidwengier davidwengier deleted the dev/dawengie/DisableRazorServerFeatureFlag branch December 27, 2023 21:15
maryamariyan
maryamariyan reviewed Jan 2, 2024
View reviewed changes
...rc/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.Custom.pkgdef
"PreviewPaneChannels"="IntPreview,int.main"

[$RootKey$\FeatureFlags\Razor\LSP\DisableRazorLanguageServer]
"Description"="Disables the Razor Language Server so that only the Cohost server is activate. This is probably a bad idea to turn on if you are not on the Razor Tooling team."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? "activate" --> "activated" or "active"

@davidwengier davidwengier mentioned this pull request Jan 4, 2024
Merged
davidwengier added a commit that referenced this pull request Jan 5, 2024
@davidwengier
Merge Cohost feature branch into main (#9786)
55551d6 
Part of #9519

Now that the initial cohost PR has been merged, we don't need to use the
feature branch any more. That means this PR, which is big, but all of
the code in it has been reviewed, in
#9761,
#9766 and
#9767.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryamariyan maryamariyan maryamariyan left review comments

@alexgav alexgav alexgav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwengier @alexgav @maryamariyan