Don't use project engines directly in the language server #9836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Jan 19, 2024
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9519
There are a few methods in the document/project snapshot system that are problematic and unnecessary in co-hosting. To make their removal from that system easier, I'm going to try to clean some things up around their use, and this is the first PR in that step, by cleaning up the
GetProjectEngine()method a little bit.The method is still there, because its used by TagHelperResolvers, but those won't be used in co-hosting so they're not a problem. A future PR will (presumably) split
IProjectSnapshotup in some way, and so the method itself won't strictly be removed, but rather just not exposed to anything in co-hosting.I did an integration test run from the midway point of this PR to ensure formatting still works, and it's green: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8939290&view=results