Fix problematic things on IProjectSnapshot #9871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Jan 29, 2024
| @@ -30,7 +32,7 @@ internal interface IProjectSnapshot | |||
| string DisplayName { get; } | |||
| VersionStamp Version { get; } | |||
| LanguageVersion CSharpLanguageVersion { get; } | |||
| ImmutableArray<TagHelperDescriptor> TagHelpers { get; } | |||
| Task<ImmutableArray<TagHelperDescriptor>> GetTagHelpersAsync(CancellationToken cancellationToken); | |||
There was a problem hiding this comment.
Consider ValueTask to avoid an extra allocation.
| @@ -33,4 +37,12 @@ public static RazorProjectInfo ToRazorProjectInfo(this IProjectSnapshot project, | |||
| projectWorkspaceState: project.ProjectWorkspaceState, | |||
| documents: documents.DrainToImmutable()); | |||
| } | |||
|
|
|||
| public static ImmutableArray<TagHelperDescriptor> GetTagHelpersSynchronously(this IProjectSnapshot projectSnapshot) | |||
There was a problem hiding this comment.
Would you mind creating an issue to clean this up? I'm about to work on VisualStudioDocumentTracker as part of the MEF clean up, and I'd be happy to get rid of this at the same time.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9519
As per our meeting the other day, there are a few things on
IProjectSnapshotthat are problematic. This PR resolves all of the issues in one of two ways:Configuration,GetProjectEngine()andProjectWorkspaceStatethe cohost implementations now simply throwDocumentStateto do jobs that the source gen will eventually take over. To make this clearer, I modified the helper methods so they took the underlying data, rather than pulling it fromIProjectSnapshotdirectlyTagHelpersproperty into aGetTagHelpersAsync(CancellationToken)methodGetTagHelpersSynchronously()extension method that validates that its not called from cohosting. It's only called from legacy editor code.Note that this isn't the proposed solution in the aforementioned meeting, that change can still come later. I was hoping to take that idea and use DI to enforce something better than just a runtime check, but it turned out that wasn't possible because some MEF services need these properties in non-cohosting. This PR at least introduces the runtime check, so we can continue moving forward.
Integration tests are running and should show up in in the checks list.