Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing IntroToRx.com content #1984

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Importing IntroToRx.com content #1984

merged 1 commit into from
Aug 11, 2023

Conversation

LeeCampbell
Copy link
Contributor

Hello and thank you for contributing to dotnet/reactive. Before you proceed by creating a pull request (PR):

Please make sure your contribution is in line with the project's licensing model and
your employment allows you to contribute to open source. ✅

Please sign the Contributor License Agreement in case the CLA bot asks you
for being a new contributor. ✅ (Approved Thu, 14 May 2015)

Please make sure you target the main branch when creating the PR. ✅

What is the nature of your contribution?

Enhancement

This PR addresses #836 and #1563 .
Discussion has occurred offsite, and an agreement has been made for myself (@LeeCampbell) to hand over the IntroToRx content to the community as long as it retains attribution.

Further edits are underway, on the original IntroToRx site - LeeCampbell/IntroToRx#36
These edits can now be migrated to this site.

Note that the content that is being imported was in an early version of markdown that was used to generate HTML for IntroToRx.com and the Kindle book available on Amazon.
As such it has formatting and content that will no longer be relevant and can be omitted.

cc @HowardvanRooijen @idg10

@idg10 idg10 merged commit 7be9ec8 into dotnet:main Aug 11, 2023
@idg10
Copy link
Collaborator

idg10 commented Aug 11, 2023

Thank you very much for this @LeeCampbell

Documentation is hugely important, and Rx in particular has some complex concepts people need to understand, so it really needs good explanations of why it works how it does, and how to use it. So we're very grateful to be able to build on your work. Your IntroToRx site was a great gift to the community, and we are excited to be able to give it a new lease of life as the basis of the main Rx.NET documentation site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants