Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to dotnet/sign #42

Closed
MattKotsenas opened this issue Jun 28, 2024 · 0 comments · Fixed by #43
Closed

Switch to dotnet/sign #42

MattKotsenas opened this issue Jun 28, 2024 · 0 comments · Fixed by #43

Comments

@MattKotsenas
Copy link
Member

We need to migrate our pipeline to https://github.com/dotnet/sign.
@MattKotsenas MattKotsenas mentioned this issue Jul 2, 2024
Merged
MattKotsenas added a commit that referenced this issue Jul 2, 2024
@MattKotsenas
Migrate from SignClient to sign tool and specify SDK in global.json (…
97f3184 
…#43)

Fixes #42

Switch to the newer dotnet/sign CLI tool. As part of the switch I
refactored the YAML file slightly:

1. Add a minimum SDK version in global.json. This helps prevent "works
on my machine" issues by ensuring that CI is running a reasonable SDK
version. I'm open to suggestions on the rollforward strategy; currently
being as permissive as possible
2. Switch the YAML from using a deployment to a regular job; deployments
aren't used very commonly and behave a bit differently (i.e. don't
clone, automatically download all artifacts, etc.) so using a regular
job to be "less magical"
3. Rather than install the sign tool in the CI pipeline, I add it as a
dotnet tool; this makes it easier to discover / upgrade versions since
that tool is stored with the others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from SignClient to sign tool and specify SDK in global.json MattKotsenas/reproducible-builds
1 participant
@MattKotsenas