Fix a couple of issues in UseExceptionThrowHelpers #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on additional false positives discovered while enabling the rules in dotnet/runtime: - We don't want to warn to use ObjectDisposedException.ThrowIf when inside of a struct, as doing so is likely to lead to additional costs (e.g. boxing). - We don't want to warn to use ArgumentXxException.ThrowIfXx when the code to compute the argument name is more complicated than just a literal / nameof, e.g. a method call that determines what parameter name should be employed.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6396 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 1361 1361
Lines 316031 316051 +20
Branches 10195 10185 -10
=======================================
+ Hits 303738 303766 +28
+ Misses 9861 9855 -6
+ Partials 2432 2430 -2 |
Youssef1313
reviewed
Jan 3, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseExceptionThrowHelpers.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 3, 2023
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseExceptionThrowHelpers.cs
Show resolved
Hide resolved
mavasani
approved these changes
Jan 3, 2023
|
Thanks for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on additional false positives discovered while enabling the rules in dotnet/runtime: