Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests to customize FixAllContext #969

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Allow tests to customize FixAllContext #969

merged 4 commits into from
Feb 22, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 19, 2022 •
edited
Loading

... and pass in internal options.

@tmat tmat requested a review from a team as a code owner February 19, 2022 20:58
@tmat tmat mentioned this pull request Feb 19, 2022
Merged
1 task
@tmat tmat enabled auto-merge (rebase) February 19, 2022 22:24
sharwell
sharwell requested changes Feb 22, 2022
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one CreateFixAllContext method should be virtual. If other overloads exist, they should ultimately delegate to the single virtual method.

@tmat
Copy link
Member Author

tmat commented Feb 22, 2022 •
edited
Loading

Removed the second overload.

@tmat tmat merged commit a42d204 into dotnet:main Feb 22, 2022
@tmat tmat deleted the FixAllContext branch February 22, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmat @sharwell