PR feedback

dotnet · Feb 20, 2024 · 004452e · 004452e
1 parent 2e5d839
commit 004452e
Show file tree

Hide file tree

Showing 4 changed files with 857 additions and 19 deletions.
diff --git a/src/Compilers/CSharp/Portable/Binder/Binder.ValueChecks.cs b/src/Compilers/CSharp/Portable/Binder/Binder.ValueChecks.cs
@@ -2729,14 +2729,11 @@ private static bool AllParametersConsideredInEscapeAnalysisHaveArguments(
         }
 #endif
 
-#nullable disable
-
         private static ErrorCode GetStandardCallEscapeError(bool checkingReceiver)
         {
             return checkingReceiver ? ErrorCode.ERR_EscapeCall2 : ErrorCode.ERR_EscapeCall;
         }
 
-#nullable enable
         private sealed class TypeParameterThisParameterSymbol : ThisParameterSymbolBase
         {
             private readonly TypeParameterSymbol _type;

diff --git a/src/Compilers/CSharp/Portable/Symbols/Source/ThisParameterSymbol.cs b/src/Compilers/CSharp/Portable/Symbols/Source/ThisParameterSymbol.cs
@@ -85,7 +85,6 @@ public sealed override ImmutableArray<CustomModifier> RefCustomModifiers
             get { return ImmutableArray<CustomModifier>.Empty; }
         }
 
-        // TODO: structs
         public sealed override bool IsThis
         {
             get { return true; }

diff --git a/src/Compilers/CSharp/Portable/Symbols/TypeSymbol.cs b/src/Compilers/CSharp/Portable/Symbols/TypeSymbol.cs
@@ -1970,9 +1970,11 @@ static void checkRefStructInterfacesFeatureAvailabilityOnUnscopedRefAttribute(Sy
                         attributeData.IsTargetAttribute(AttributeDescription.UnscopedRefAttribute))
                     {
                         MessageID.IDS_RefStructInterfaces.CheckFeatureAvailability(diagnostics, implementingSymbol.DeclaringCompilation, applicationSyntaxReference.GetLocation());
-                        break;
+                        return;
                     }
                 }
+
+                Debug.Assert(false);
             }
         }