Run analyzer on IDE

dotnet · Feb 22, 2023 · 542ddeb · 542ddeb
1 parent 7347efa
commit 542ddeb
Show file tree

Hide file tree

Showing 38 changed files with 103 additions and 103 deletions.
diff --git a/...lyzers/Core/Analyzers/Helpers/HashCodeAnalyzer/HashCodeAnalyzer.OperationDeconstructor.cs b/...lyzers/Core/Analyzers/Helpers/HashCodeAnalyzer/HashCodeAnalyzer.OperationDeconstructor.cs
@@ -37,10 +37,10 @@ public OperationDeconstructor(
                 _accessesBase = false;
             }
 
-            public void Dispose()
+            public readonly void Dispose()
                 => _hashedSymbols.Free();
 
-            public (bool accessesBase, ImmutableArray<ISymbol> hashedSymbol) GetResult()
+            public readonly (bool accessesBase, ImmutableArray<ISymbol> hashedSymbol) GetResult()
                 => (_accessesBase, _hashedSymbols.ToImmutable());
 
             /// <summary>
@@ -194,7 +194,7 @@ private static bool TryGetFieldOrProperty(IOperation operation, [NotNullWhen(tru
                 return false;
             }
 
-            private bool TryAddSymbol(ISymbol member)
+            private readonly bool TryAddSymbol(ISymbol member)
             {
                 // Not a legal GetHashCode to convert if we refer to members multiple times.
                 if (_hashedSymbols.Contains(member))

diff --git a/src/Dependencies/CodeAnalysis.Debugging/CustomDebugInfoEncoder.cs b/src/Dependencies/CodeAnalysis.Debugging/CustomDebugInfoEncoder.cs
@@ -37,10 +37,10 @@ public CustomDebugInfoEncoder(BlobBuilder builder)
             builder.WriteInt16(0);
         }
 
-        public int RecordCount => _recordCount;
+        public readonly int RecordCount => _recordCount;
 
         /// <exception cref="InvalidOperationException">More than <see cref="byte.MaxValue"/> records added.</exception>
-        public byte[] ToArray()
+        public readonly byte[] ToArray()
         {
             if (_recordCount == 0)
             {

diff --git a/src/Dependencies/Collections/ImmutableSegmentedHashSet`1+Enumerator.cs b/src/Dependencies/Collections/ImmutableSegmentedHashSet`1+Enumerator.cs
@@ -25,7 +25,7 @@ internal Enumerator(SegmentedHashSet<T> set)
             /// <inheritdoc cref="ImmutableHashSet{T}.Enumerator.Current"/>
             public T Current => _enumerator.Current;
 
-            object? IEnumerator.Current => ((IEnumerator)_enumerator).Current;
+            readonly object? IEnumerator.Current => ((IEnumerator)_enumerator).Current;
 
             /// <inheritdoc cref="ImmutableHashSet{T}.Enumerator.Dispose()"/>
             public void Dispose()

diff --git a/src/Dependencies/Collections/ImmutableSegmentedList`1+Enumerator.cs b/src/Dependencies/Collections/ImmutableSegmentedList`1+Enumerator.cs
@@ -22,7 +22,7 @@ internal Enumerator(SegmentedList<T> list)
 
             public T Current => _enumerator.Current;
 
-            object? IEnumerator.Current => ((IEnumerator)_enumerator).Current;
+            readonly object? IEnumerator.Current => ((IEnumerator)_enumerator).Current;
 
             public void Dispose()
                 => _enumerator.Dispose();

diff --git a/src/Dependencies/Collections/ImmutableSegmentedList`1+ValueBuilder.cs b/src/Dependencies/Collections/ImmutableSegmentedList`1+ValueBuilder.cs
@@ -32,17 +32,17 @@ internal ValueBuilder(ImmutableSegmentedList<T> list)
 
             public int Count => ReadOnlyList.Count;
 
-            private SegmentedList<T> ReadOnlyList => _mutableList ?? _list._list;
+            private readonly SegmentedList<T> ReadOnlyList => _mutableList ?? _list._list;
 
-            bool ICollection<T>.IsReadOnly => false;
+            readonly bool ICollection<T>.IsReadOnly => false;
 
-            bool IList.IsFixedSize => false;
+            readonly bool IList.IsFixedSize => false;
 
-            bool IList.IsReadOnly => false;
+            readonly bool IList.IsReadOnly => false;
 
-            bool ICollection.IsSynchronized => false;
+            readonly bool ICollection.IsSynchronized => false;
 
-            object ICollection.SyncRoot => throw new NotSupportedException();
+            readonly object ICollection.SyncRoot => throw new NotSupportedException();
 
             public T this[int index]
             {

diff --git a/src/Dependencies/Collections/Internal/BitHelper.cs b/src/Dependencies/Collections/Internal/BitHelper.cs
@@ -26,7 +26,7 @@ internal BitHelper(Span<int> span, bool clear)
             _span = span;
         }
 
-        internal void MarkBit(int bitPosition)
+        internal readonly void MarkBit(int bitPosition)
         {
             var bitArrayIndex = bitPosition / IntSize;
             if ((uint)bitArrayIndex < (uint)_span.Length)
@@ -35,7 +35,7 @@ internal void MarkBit(int bitPosition)
             }
         }
 
-        internal bool IsMarked(int bitPosition)
+        internal readonly bool IsMarked(int bitPosition)
         {
             var bitArrayIndex = bitPosition / IntSize;
             return

diff --git a/src/Dependencies/Collections/SegmentedArray.cs b/src/Dependencies/Collections/SegmentedArray.cs
@@ -465,7 +465,7 @@ public AlignedSegmentEnumerator(T[][] firstSegments, int firstOffset, T[][] seco
                 _current = (Memory<T>.Empty, Memory<T>.Empty);
             }
 
-            public (Memory<T> first, Memory<T> second) Current => _current;
+            public readonly (Memory<T> first, Memory<T> second) Current => _current;
 
             public bool MoveNext()
             {
@@ -570,7 +570,7 @@ public UnalignedSegmentEnumerator(T[][] firstSegments, int firstOffset, T[][] se
                 _current = (Memory<T>.Empty, Memory<T>.Empty);
             }
 
-            public (Memory<T> first, Memory<T> second) Current => _current;
+            public readonly (Memory<T> first, Memory<T> second) Current => _current;
 
             public bool MoveNext()
             {
@@ -618,7 +618,7 @@ public Reverse(T[][] firstSegments, int firstOffset, T[][] secondSegments, int s
                     _current = (Memory<T>.Empty, Memory<T>.Empty);
                 }
 
-                public (Memory<T> first, Memory<T> second) Current => _current;
+                public readonly (Memory<T> first, Memory<T> second) Current => _current;
 
                 public bool MoveNext()
                 {
@@ -710,7 +710,7 @@ public SegmentEnumerator(T[][] segments, int offset, int length)
                 _current = Memory<T>.Empty;
             }
 
-            public Memory<T> Current => _current;
+            public readonly Memory<T> Current => _current;
 
             public bool MoveNext()
             {
@@ -759,7 +759,7 @@ public Reverse(T[][] segments, int offset, int length)
                     _current = Memory<T>.Empty;
                 }
 
-                public Memory<T> Current => _current;
+                public readonly Memory<T> Current => _current;
 
                 public bool MoveNext()
                 {

diff --git a/src/Dependencies/Collections/SegmentedArray`1.cs b/src/Dependencies/Collections/SegmentedArray`1.cs
@@ -386,10 +386,10 @@ public Enumerator(SegmentedArray<T> array)
                 _current = default!;
             }
 
-            public T Current => _current;
+            public readonly T Current => _current;
             object? IEnumerator.Current => Current;
 
-            public void Dispose()
+            public readonly void Dispose()
             {
             }
 

diff --git a/src/Dependencies/Collections/SegmentedDictionary`2.cs b/src/Dependencies/Collections/SegmentedDictionary`2.cs
@@ -1178,13 +1178,13 @@ public bool MoveNext()
                 return false;
             }
 
-            public KeyValuePair<TKey, TValue> Current => _current;
+            public readonly KeyValuePair<TKey, TValue> Current => _current;
 
-            public void Dispose()
+            public readonly void Dispose()
             {
             }
 
-            object? IEnumerator.Current
+            readonly object? IEnumerator.Current
             {
                 get
                 {
@@ -1213,7 +1213,7 @@ void IEnumerator.Reset()
                 _current = default;
             }
 
-            DictionaryEntry IDictionaryEnumerator.Entry
+            readonly DictionaryEntry IDictionaryEnumerator.Entry
             {
                 get
                 {
@@ -1226,7 +1226,7 @@ DictionaryEntry IDictionaryEnumerator.Entry
                 }
             }
 
-            object IDictionaryEnumerator.Key
+            readonly object IDictionaryEnumerator.Key
             {
                 get
                 {
@@ -1239,7 +1239,7 @@ object IDictionaryEnumerator.Key
                 }
             }
 
-            object? IDictionaryEnumerator.Value
+            readonly object? IDictionaryEnumerator.Value
             {
                 get
                 {
@@ -1398,7 +1398,7 @@ internal Enumerator(SegmentedDictionary<TKey, TValue> dictionary)
                     _currentKey = default;
                 }
 
-                public void Dispose()
+                public readonly void Dispose()
                 {
                 }
 
@@ -1425,9 +1425,9 @@ public bool MoveNext()
                     return false;
                 }
 
-                public TKey Current => _currentKey!;
+                public readonly TKey Current => _currentKey!;
 
-                object? IEnumerator.Current
+                readonly object? IEnumerator.Current
                 {
                     get
                     {
@@ -1598,7 +1598,7 @@ internal Enumerator(SegmentedDictionary<TKey, TValue> dictionary)
                     _currentValue = default;
                 }
 
-                public void Dispose()
+                public readonly void Dispose()
                 {
                 }
 
@@ -1624,9 +1624,9 @@ public bool MoveNext()
                     return false;
                 }
 
-                public TValue Current => _currentValue!;
+                public readonly TValue Current => _currentValue!;
 
-                object? IEnumerator.Current
+                readonly object? IEnumerator.Current
                 {
                     get
                     {

diff --git a/src/Dependencies/Collections/SegmentedHashSet`1.cs b/src/Dependencies/Collections/SegmentedHashSet`1.cs
@@ -1422,11 +1422,11 @@ public bool MoveNext()
                 return false;
             }
 
-            public T Current => _current;
+            public readonly T Current => _current;
 
-            public void Dispose() { }
+            public readonly void Dispose() { }
 
-            object? IEnumerator.Current
+            readonly object? IEnumerator.Current
             {
                 get
                 {

diff --git a/src/Dependencies/Collections/SegmentedList`1.cs b/src/Dependencies/Collections/SegmentedList`1.cs
@@ -1176,7 +1176,7 @@ internal Enumerator(SegmentedList<T> list)
                 _current = default;
             }
 
-            public void Dispose()
+            public readonly void Dispose()
             {
             }
 
@@ -1205,7 +1205,7 @@ private bool MoveNextRare()
                 return false;
             }
 
-            public T Current => _current!;
+            public readonly T Current => _current!;
 
             object? IEnumerator.Current
             {

diff --git a/src/Dependencies/PooledObjects/ArrayBuilder.Enumerator.cs b/src/Dependencies/PooledObjects/ArrayBuilder.Enumerator.cs
@@ -20,7 +20,7 @@ public Enumerator(ArrayBuilder<T> builder)
                 _index = -1;
             }
 
-            public T Current
+            public readonly T Current
             {
                 get
                 {

diff --git a/src/EditorFeatures/TestUtilities/EditAndContinue/MatchingPair.cs b/src/EditorFeatures/TestUtilities/EditAndContinue/MatchingPair.cs
@@ -16,7 +16,7 @@ public struct MatchingPair
         public string Old;
         public string New;
 
-        public override string ToString()
+        public override readonly string ToString()
             => "{ \"" + Old.Replace("\"", "\\\"") + "\", \"" + New.Replace("\"", "\\\"") + "\" }";
     }
 

diff --git a/src/EditorFeatures/TestUtilities/Rename/RenamerTests.cs b/src/EditorFeatures/TestUtilities/Rename/RenamerTests.cs
@@ -29,7 +29,7 @@ protected struct DocumentWithInfo
             public string Text { get; set; }
             public string DocumentName { get; set; }
             public string DocumentFilePath { get; set; }
-            public string[] DocumentFolders => GetDocumentFolders(DocumentFilePath);
+            public readonly string[] DocumentFolders => GetDocumentFolders(DocumentFilePath);
         }
 
         protected async Task TestRenameDocument(

diff --git a/src/ExpressionEvaluator/Core/Source/ResultProvider/Helpers/TypeWalker.cs b/src/ExpressionEvaluator/Core/Source/ResultProvider/Helpers/TypeWalker.cs
@@ -36,7 +36,7 @@ public TypeEnumerator(Type type)
                 _stack.Push(type);
             }
 
-            public Type Current => _stack.Peek();
+            public readonly Type Current => _stack.Peek();
 
             public bool MoveNext()
             {

diff --git a/src/ExpressionEvaluator/Core/Test/ResultProvider/Debugger/Engine/DkmEvaluationAsyncResult.cs b/src/ExpressionEvaluator/Core/Test/ResultProvider/Debugger/Engine/DkmEvaluationAsyncResult.cs
@@ -29,7 +29,7 @@ public DkmEvaluationAsyncResult(DkmEvaluationResult Result)
 
         public int ErrorCode { get { throw new NotImplementedException(); } }
 
-        public DkmEvaluationResult Result { get { return _result; } }
+        public readonly DkmEvaluationResult Result { get { return _result; } }
 
         internal Exception Exception { get; set; }
 

diff --git a/src/Features/Core/Portable/EmbeddedLanguages/Json/JsonLexer.cs b/src/Features/Core/Portable/EmbeddedLanguages/Json/JsonLexer.cs
@@ -29,12 +29,12 @@ public JsonLexer(VirtualCharSequence text) : this()
             Text = text;
         }
 
-        public VirtualChar CurrentChar => Text[Position];
+        public readonly VirtualChar CurrentChar => Text[Position];
 
         public VirtualCharSequence GetCharsToCurrentPosition(int start)
             => GetSubSequence(start, Position);
 
-        public VirtualCharSequence GetSubSequence(int start, int end)
+        public readonly VirtualCharSequence GetSubSequence(int start, int end)
             => Text.GetSubSequence(TextSpan.FromBounds(start, end));
 
         public JsonToken ScanNextToken()
@@ -314,13 +314,13 @@ private JsonTrivia ScanMultiLineComment()
                 new EmbeddedDiagnostic(FeaturesResources.Unterminated_comment, GetTextSpan(start, Position)));
         }
 
-        private TextSpan GetTextSpan(int startInclusive, int endExclusive)
+        private readonly TextSpan GetTextSpan(int startInclusive, int endExclusive)
             => TextSpan.FromBounds(Text[startInclusive].Span.Start, Text[endExclusive - 1].Span.End);
 
         private bool IsAt(string val)
             => TextAt(this.Position, val);
 
-        private bool TextAt(int position, string val)
+        private readonly bool TextAt(int position, string val)
         {
             for (var i = 0; i < val.Length; i++)
             {

diff --git a/src/Features/Core/Portable/EmbeddedLanguages/Json/JsonParser.cs b/src/Features/Core/Portable/EmbeddedLanguages/Json/JsonParser.cs
@@ -360,7 +360,7 @@ private JsonSeparatedList ParseCommaSeparatedSequenceWorker()
             return new JsonSeparatedList(result.ToImmutable());
         }
 
-        private bool ShouldConsumeSequenceElement()
+        private readonly bool ShouldConsumeSequenceElement()
             => _currentToken.Kind switch
             {
                 JsonKind.EndOfFile => false,
@@ -587,7 +587,7 @@ private JsonToken ConsumeToken(JsonKind kind, string? error)
             return result.AddDiagnosticIfNone(new EmbeddedDiagnostic(error, GetTokenStartPositionSpan(_currentToken)));
         }
 
-        private TextSpan GetTokenStartPositionSpan(JsonToken token)
+        private readonly TextSpan GetTokenStartPositionSpan(JsonToken token)
             => token.Kind == JsonKind.EndOfFile
                 ? new TextSpan(_lexer.Text.Last().Span.End, 0)
                 : new TextSpan(token.VirtualChars[0].Span.Start, 0);

diff --git a/src/Features/Core/Portable/EmbeddedLanguages/RegularExpressions/RegexLexer.cs b/src/Features/Core/Portable/EmbeddedLanguages/RegularExpressions/RegexLexer.cs
@@ -46,12 +46,12 @@ internal struct RegexLexer
         public RegexLexer(VirtualCharSequence text) : this()
             => Text = text;
 
-        public VirtualChar CurrentChar => Position < Text.Length ? Text[Position] : default;
+        public readonly VirtualChar CurrentChar => Position < Text.Length ? Text[Position] : default;
 
         public VirtualCharSequence GetSubPatternToCurrentPos(int start)
             => GetSubPattern(start, Position);
 
-        public VirtualCharSequence GetSubPattern(int start, int end)
+        public readonly VirtualCharSequence GetSubPattern(int start, int end)
             => Text.GetSubSequence(TextSpan.FromBounds(start, end));
 
         public RegexToken ScanNextToken(bool allowTrivia, RegexOptions options)
@@ -175,13 +175,13 @@ private ImmutableArray<RegexTrivia> ScanLeadingTrivia(bool allowTrivia, RegexOpt
             return null;
         }
 
-        public TextSpan GetTextSpan(int startInclusive, int endExclusive)
+        public readonly TextSpan GetTextSpan(int startInclusive, int endExclusive)
             => TextSpan.FromBounds(Text[startInclusive].Span.Start, Text[endExclusive - 1].Span.End);
 
         public bool IsAt(string val)
             => TextAt(this.Position, val);
 
-        private bool TextAt(int position, string val)
+        private readonly bool TextAt(int position, string val)
         {
             for (var i = 0; i < val.Length; i++)
             {
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,7 +20,7 @@ public Enumerator(ArrayBuilder<T> builder) @@
                     _index = -1;
                 }
-                public T Current
+                public readonly T Current
                 {
                     get
                     {
@@ Expand Down @@