Make VBCSCompiler pipe name insensitive to casing of the path (#75852)

* Make VBCSCompiler pipe name insensitive to casing of the path * Improve comment wording Co-authored-by: Jared Parsons <[email protected]> --------- Co-authored-by: Jared Parsons <[email protected]>
dotnet · Nov 12, 2024 · d3176f5 · d3176f5
1 parent 5780d35
commit d3176f5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Compilers/Server/VBCSCompilerTests/BuildClientTests.cs b/src/Compilers/Server/VBCSCompilerTests/BuildClientTests.cs
@@ -344,6 +344,14 @@ public void GetPipeNameForPathOptLength()
                 // We only have ~50 total bytes to work with on mac, so the base path must be small
                 Assert.Equal(43, name.Length);
             }
+
+            [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/75714")]
+            public void GetPipeNameForPath_Casing()
+            {
+                var path1 = string.Format(@"q:{0}the{0}path", Path.DirectorySeparatorChar);
+                var path2 = string.Format(@"Q:{0}The{0}Path", Path.DirectorySeparatorChar);
+                Assert.Equal(BuildServerConnection.GetPipeName(path1), BuildServerConnection.GetPipeName(path2));
+            }
         }
     }
 }
diff --git a/src/Compilers/Shared/BuildServerConnection.cs b/src/Compilers/Shared/BuildServerConnection.cs
@@ -564,6 +564,9 @@ internal static string GetPipeName(
             // of this method.
             clientDirectory = clientDirectory.TrimEnd(Path.DirectorySeparatorChar);
 
+            // Similarly, we don't want multiple servers if the provided launch path differs in casing.
+            clientDirectory = clientDirectory.ToLowerInvariant();
+
             var pipeNameInput = $"{userName}.{isAdmin}.{clientDirectory}";
             using (var sha = SHA256.Create())
             {