Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete FatalError.ReportIfNonFatalAndCatchUnlessCanceled #58375

Closed
jasonmalinowski opened this issue Dec 16, 2021 · 1 comment · Fixed by #58870
Closed

Delete FatalError.ReportIfNonFatalAndCatchUnlessCanceled #58375

jasonmalinowski opened this issue Dec 16, 2021 · 1 comment · Fixed by #58870
Assignees
@jasonmalinowski
Labels
Area-IDE Concept-Continuous Improvement

Comments

@jasonmalinowski
Copy link
Member

jasonmalinowski commented Dec 16, 2021 •
edited
Loading

#58094 introduced this method as a shim for several places in the compiler that needed that specific behavior. It was agreed that we really don't want that behavior, but it was prudent to not change things for 17.1 given our relative lateness in the cycle. We want to rip it out immediately at the start of 17.2, so if there are any bugs still being masked we can have sufficient time to react to them.

The last commit in the PR details the precise set of steps we want to do to undo it.
@jasonmalinowski jasonmalinowski added this to the 17.2 milestone Dec 16, 2021
@jasonmalinowski jasonmalinowski self-assigned this Dec 16, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 16, 2021
@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 5, 2022
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Jan 14, 2022
@jasonmalinowski
Remove places where the compiler is swallowing exceptions
b2719a2 
There are a few places where compiler APIs are swallowing internal
exceptions and returning null from APIs as a way to march on; this
removes those places, and then removes our ReportAndCatch* APIs from
the compiler layer entirely. We currently have no (cross platform)
way of implementing those in a way that would allow for non-fatal error
reporting.

Closes dotnet#58375
@jasonmalinowski jasonmalinowski mentioned this issue Jan 14, 2022
Merged
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Jan 28, 2022
@jasonmalinowski
Remove places where the compiler is swallowing exceptions
d23fe1e 
There are a few places where compiler APIs are swallowing internal
exceptions and returning null from APIs as a way to march on; this
removes those places, and then removes our ReportAndCatch* APIs from
the compiler layer entirely. We currently have no (cross platform)
way of implementing those in a way that would allow for non-fatal error
reporting.

Closes dotnet#58375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove places where the compiler is swallowing exceptions jasonmalinowski/roslyn
3 participants
@jaredpar @jasonmalinowski @jinujoseph