Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable execution of test scenarios with implementation of static members in derived interfaces once runtime can handle it. #61321

Closed
AlekseyTs opened this issue May 14, 2022 · 1 comment · Fixed by #75670
Assignees
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Feature - Default Interface Impl Default Interface Implementation Feature - StaticAbstractMembersInInterfaces
Milestone

Comments

@AlekseyTs
Copy link
Contributor

In src\Compilers\CSharp\Test\Symbol\Symbols\DefaultInterfaceImplementationTests.cs:

        private static bool Execute(bool isStatic, bool haveImplementationInDerivedInterface = false)
        {
            // PROTOTYPE(DefaultInterfaceImplementation) : Enable execution for isStatic and haveImplementationInDerivedInterface once runtime can handle it.
            if (!ExecutionConditionUtil.IsMonoOrCoreClr || (isStatic && haveImplementationInDerivedInterface))
            {
                return false;
            }

#if !NET7_0_OR_GREATER
            if (isStatic)
            {
                return false;
            }
#endif

            return true;
        }
@AlekseyTs
Copy link
Contributor Author

Scenarios with re-abstraction are still blocked by dotnet/runtime#80350

@jaredpar jaredpar added this to the Backlog milestone Jul 23, 2024
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Oct 29, 2024
@AlekseyTs AlekseyTs added the 4 - In Review A fix for the issue is submitted for review. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Feature - Default Interface Impl Default Interface Implementation Feature - StaticAbstractMembersInInterfaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants