Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUGGESTION] Solution-wide analysis #104 #68553

Closed
arunchndr opened this issue Jun 12, 2023 · 2 comments · Fixed by dotnet/vscode-csharp#5868
Closed

[SUGGESTION] Solution-wide analysis #104 #68553

arunchndr opened this issue Jun 12, 2023 · 2 comments · Fixed by dotnet/vscode-csharp#5868
Assignees
@mavasani
Labels
Area-IDE Feature Request VSCode

Comments

@arunchndr
Copy link
Member

Currently C# Dev Kit reports errors/warnings about opened files.
Can it automatically report solution-wide errors/warnings?

Refer microsoft/vscode-dotnettools#104 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 12, 2023
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 12, 2023
@arunchndr arunchndr mentioned this issue Jun 12, 2023
Closed
@ivanjx
Copy link

ivanjx commented Jun 16, 2023

isnt full solution analysis already available in roslyn? the old c# extension has it. only not working in the new c# devkit extension

@segln
Copy link

segln commented Jun 16, 2023

I think so. But they closed and moved.

mavasani added a commit to mavasani/roslyn that referenced this issue Jun 27, 2023
@mavasani
Roslyn side changes to enable full solution background analysis in LS…
a03adcc 
…P/VSCode

Work towards dotnet#68553.
This needs a corresponding change in dotnet/vscode-csharp repo. I verified that this change + the corresponding vscode-csharp change enables FSA support in C# DevKit extension in VSCode.

There also needs to be a follow-up bug fix for dotnet#68797 to treat compiler and analyzer FSA options appropriately.
mavasani added a commit to mavasani/roslyn that referenced this issue Jun 27, 2023
@mavasani
Roslyn side changes to enable full solution background analysis in LS…
0f3200c 
…P/VSCode

Work towards dotnet#68553.
This needs a corresponding change in dotnet/vscode-csharp repo. I verified that this change + the corresponding vscode-csharp change enables FSA support in C# DevKit extension in VSCode.

Needs couple more Roslyn side fixes as a follow-up: dotnet#68797 and dotnet#68798
This was referenced Jun 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-IDE Feature Request VSCode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable full solution background analysis mavasani/vscode-csharp
4 participants
@mavasani @ivanjx @segln @arunchndr