fixed DeclarationNameCompletionProvider when used via Nuget package

[filipw]

Microsoft.CodeAnalysis.CSharp.Features doesn't declare Humanizer as a dependency - instead it uses PrivateAssets="all".
PrivateAssets is intended for build-time dependencies only, so the result is that the produced Nuget package doesn't contain the Humanizer.dll nor does it list it as a dependency.

This is a regression that started with Roslyn 2.11.x-beta and continues into Roslyn 3.x, because it used to work.

The consequence of the missing Humanizer is that the DeclarationNameCompletionProvider silently breaks when used via the Nuget package. It ends up throwing an exception about missing Humanizer reference but that exception is swallowed.

This actually broke declaration name completion in OmniSharp and shipped into the latest version of C# extension for VS Code. The current workaround is to reference Humanizer directly in the host application, but obviously the Nuget package should be fixed too.

For the record - repro steps:

          // reference Microsoft.CodeAnalysis.CSharp.Features Nuget

          var host = MefHostServices.Create(MefHostServices.DefaultAssemblies);
          var workspace = new AdhocWorkspace(host);

            var code = @"using System;

            public class MyClass
            {
                public static void MyMethod(int value)
                {
                    MyClass 
                }
            }";

            var projectInfo = ProjectInfo.Create(ProjectId.CreateNewId(), VersionStamp.Create(), "MyProject", "MyProject", LanguageNames.CSharp).
                WithMetadataReferences(new[] { MetadataReference.CreateFromFile(typeof(object).Assembly.Location) });
            var project = workspace.AddProject(projectInfo);
            var document = workspace.AddDocument(project.Id, "MyFile.cs", SourceText.From(code));

            var completionService = CompletionService.GetService(document);
            var results = await completionService.GetCompletionsAsync(document, code.LastIndexOf("MyClass ") + 8);

            // results is null (exception gets swallowed), instead of a completion list with entries like "my", "myClass", "My", "MyClass"

[sharwell]

Humanizer is an optional dependency of the package. It can be provided by the consumer to enable support for DeclarationNameCompletionProvider, or omitted by the consumer if that support is not needed.

[filipw]

Humanizer is an optional dependency of the package. It can be provided by the consumer to enable support for DeclarationNameCompletionProvider, or omitted by the consumer if that support is not needed.

I think it it is quite weird, to say the least, that a package is published in a state in which there are features and types that throw silent exceptions and don't work until you install a 3rd party package? IMHO Roslyn deliverables should be such that you can just install them from nuget and run.

If a dependency on Humanizer is a blocker, perhaps DeclarationNameCompletionProvider ought to be extracted into its own optional package rather than shipping in a broken state?

That said, I hope the change to PrivateAssets="compile" is OK with you 😀

[filipw]

is there any chance of this getting merged? with the current setup the feature is silently broken..