Add integration test to configure diagnostic severity via editorconfig #46639
Conversation
For reasons that aren't entirely clear, when we create a preview of a code fix, we remove and re-add documents that are being changed when we produce the PreviewWorkspace. This process had an bug which meant that the file path of an .editorconfig got dropped, so the resultant .editorconfig document path was null. This later caused a crash if the diagnostic engine, when processing the PreviewWorkspace's new solution, tried asking for a Compilation, since the null path would get passed to AnalyzerConfig.Parse(), and it would throw. This was exposed by dotnet#45076; until then if you had a preview of just an .editorconfig file, nothing would actually be analyzed and so nothing asked for the Compilation. The crash is "fixed" by dotnet#44331 in that asking for a Compilation no longer results in a call to AnalyzerConfig.Parse(); you have to ask for a Compilation and then do something with a semantic model. By luck, that doesn't happen in the common repro, but more obscure things absolutely could still fail. This is being tested by the integration test being added in dotnet#46639. We don't really have a good unit tests here as far as I can tell, but even then a unit test really doesn't validate any of the end-to-end here. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1162464
|
Ping @jasonmalinowski @dotnet/roslyn-ide |
Even if we can make this validate the preview, no reason to hold this up before we get that in.| "Warning", | ||
| "Error", | ||
| }; | ||
| VisualStudio.Editor.Verify.CodeActions(expectedItems, applyFix: "Error", ensureExpectedItemsAreOrdered: true); |
There was a problem hiding this comment.
Is there some way to have this validate the preview?
There was a problem hiding this comment.
I tried to thread in a delay between the action being computed and applied, and the integration test does wait after bringing up the light bulb, but the integration test does not expand the nested actions and hence do not bring up the preview. We either need to figure out some other way to test preview OR write a dummy test analyzer that registers a top level code action to update the .editorconfig, though I am not sure if our integration tests can run with a custom defined analyzer that is not in the box.
In short, I could not find an easy way to validate the preview.
|
I'll merge this test as it seems useful by itself, even if it doesn't validate the preview currently - it will still validate applying a code fix from IDE that updates editorconfig and validates the change in reported diagnostic severity. |
ghost
added this to the 
No description provided.