Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check operations when doing type name simplification #58285

Merged
merged 7 commits into from
Dec 14, 2021
Merged

Check operations when doing type name simplification #58285

merged 7 commits into from
Dec 14, 2021

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #57767

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 12, 2021 00:19
CyrusNajmabadi
CyrusNajmabadi commented Dec 12, 2021
View reviewed changes
src/EditorFeatures/VisualBasicTest/SimplifyTypeNames/SimplifyTypeNamesTests.vb
@@ -977,7 +977,7 @@ End Namespace")
Public Async Function TestSimplifyTypeInScriptCode() As Task
Await TestAsync(
"Imports System
[|System.Console.WriteLine(0)|]",
[|System.Console|].WriteLine(0)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old test span was incorrect (but the test still worked because of bugs in the analyzer). With the PR we still offer the fix but on the right span.

davidwengier
davidwengier approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I in no way understand this (isn't it an instance call before and after, just on the wrong target after the casts were removed?) but I trust that you know what you're doing and the tests pass :D

This was referenced Dec 13, 2021
Closed
Closed
@runfoapp runfoapp bot mentioned this pull request Dec 13, 2021
Closed
@CyrusNajmabadi CyrusNajmabadi merged commit 85f60db into dotnet:main Dec 14, 2021
@ghost ghost added this to the Next milestone Dec 14, 2021
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the speculationOperation branch March 2, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.1.P3
Development

Successfully merging this pull request may close these issues.

"Name can be simplified" code fix results in invalid code (build error)
3 participants
@CyrusNajmabadi @davidwengier @Cosifne