Move diagnostic service to LSP layer #59456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
reviewed
Feb 10, 2022
...lyzers/Core/Analyzers/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
force-pushed
the
DiagnosticIncrementalAnalzyer
branch
4 times, most recently
from
0e94556
to
c2d233e
Compare
tmat
force-pushed
the
DiagnosticIncrementalAnalzyer
branch
4 times, most recently
from
3d464c5
to
e8893a2
Compare
tmat
changed the title
dibarbet
approved these changes
Feb 23, 2022
|
This should most likely have a val build as well |
tmat
force-pushed
the
DiagnosticIncrementalAnalzyer
branch
from
5dca558
to
23bb31a
Compare
mavasani
reviewed
Feb 25, 2022
src/EditorFeatures/Test/Diagnostics/DiagnosticAnalyzerServiceTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
src/EditorFeatures/Test/Diagnostics/DiagnosticAnalyzerServiceTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
src/Features/Core/Portable/SolutionCrawler/AggregateIncrementalAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
src/Features/Core/Portable/SolutionCrawler/AggregateIncrementalAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
src/Features/Core/Portable/SolutionCrawler/IncrementalAnalyzerBase.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
src/Features/Core/Portable/SolutionCrawler/WorkCoordinator.NormalPriorityProcessor.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
src/Features/Core/Portable/SolutionCrawler/WorkCoordinator.NormalPriorityProcessor.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
...atures/LanguageServer/Protocol/Features/CodeFixes/CodeFixService.FixAllDiagnosticProvider.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
...tures/LanguageServer/Protocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.cs
Show resolved
Hide resolved
mavasani
reviewed
Feb 25, 2022
mavasani
approved these changes
Feb 25, 2022
tmat
force-pushed
the
DiagnosticIncrementalAnalzyer
branch
from
b96d302
to
c499d15
Compare
4 tasks
tmat
force-pushed
the
DiagnosticIncrementalAnalzyer
branch
2 times, most recently
from
705f05f
to
45e6350
Compare
tmat
force-pushed
the
DiagnosticIncrementalAnalzyer
branch
from
45e6350
to
2a96692
Compare
Refactor AnalyzerHelpers Remove IIncementalAnalyzer2 Move DiagnosticService to LSP layer Move DiagnosticIncrementalAnalyzer to LSP Move *OptionsStorage types Simplify CodeFixService Move CodeFixService and CodeCleanupService to LSP layer Include LSP layer in EditorFeatures test composition
tmat
force-pushed
the
DiagnosticIncrementalAnalzyer
branch
from
2a96692
to
2f21400
Compare
ghost
added this to the
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move diagnostic service and all code that depends on it out of Features layer to LSP layer.
This code is currently client code - it does not run OOP but also does not have dependency on editor. The code will be further simplified/eliminated once we transition to pull diagnostics.
Split AnalyzerHelpers helpers among AnalyzerOptionsExtensions in Features, AnalyzerOptionsExtensions in Analyzers shared project, DiagnosticAnalyzerExtensions and DocumentAnalysisExecutor.
Removes IIncrementalAnalyzer2.
Simplify CodeFixService.FixAllDiagnosticProvider.
Move ClassificationOptionsStorage, CompletionOptionStorage and SignatureHelpOptionsStorage to LSP layer.
Fixes #59184
Fixes #45936
Requires: