Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to fixup code when user transposes 'record' in a declaration #59652

Merged
merged 5 commits into from
Mar 1, 2022
Merged

Add feature to fixup code when user transposes 'record' in a declaration #59652

merged 5 commits into from
Mar 1, 2022

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Feb 18, 2022 •
edited
Loading

Followup to #59622

Looks like:

image

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners February 18, 2022 20:37
davidwengier
davidwengier approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE bits make sense, though I think the fixer name should change.

src/Analyzers/CSharp/CodeFixes/CSharpCodeFixesResources.resx Outdated Show resolved Hide resolved
...yzers/CSharp/CodeFixes/TransposeRecordKeyword/CSharpTransposeRecordKeywordCodeFixProvider.cs Outdated Show resolved Hide resolved
...yzers/CSharp/CodeFixes/TransposeRecordKeyword/CSharpTransposeRecordKeywordCodeFixProvider.cs Outdated Show resolved Hide resolved
@davidwengier
Copy link
Contributor

Very nice :)

@jcouv jcouv force-pushed the offerToSwapMisplacedKeyword branch from 1df28cc to a1dd95c Compare March 1, 2022 18:29
@jcouv
Copy link
Member

jcouv commented Mar 1, 2022

Rebased since #59622 was just merged/squashed. It went smoothly (did git rebase -i dotnet/main and just deleted the first four commits from that previous PR; merges didn't cause any issues).
I verified things still build.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge March 1, 2022 19:38
@CyrusNajmabadi CyrusNajmabadi merged commit 53b34d4 into dotnet:main Mar 1, 2022
@ghost ghost added this to the Next milestone Mar 1, 2022
@jcouv jcouv mentioned this pull request Mar 2, 2022
Closed
@CyrusNajmabadi CyrusNajmabadi deleted the offerToSwapMisplacedKeyword branch March 2, 2022 22:11
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
Compiler: Julien's umbrellas
Archived in project
Milestone
17.2.P3
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @davidwengier @jcouv @allisonchou