-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge features/rename_ui_rework into main #59779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… back to old UI for now.
This adds the most basic implementation of the new rename UI. This PR is mostly to move code around and start a very ugly but workable demo. None of the behavior in the new UI is final, but it should make subsequent code reviews easier to parse in chunks as we modify the behavior.
Update features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
Features/rename_UI_rework Merge Main
…ui_rework Merge main to features/rename_ui_rework
Merge main into feature branch
…merges/main-to-features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
…ui_rework Merge main to features/rename_ui_rework
@JoeRobich could I get a sign-off please :) |
JoeRobich
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the new UI for rename into main, disabled by default