Don't get nullable slot if property sub-pattern has error #59813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Feb 28, 2022
src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker_Patterns.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Mar 1, 2022
333fred
reviewed
Mar 1, 2022
Comment on lines
190
to
191
| if (subpattern.Member is BoundPropertySubpatternMember member | ||
| && member.Symbol.Kind is SymbolKind.Property or SymbolKind.Field) |
There was a problem hiding this comment.
subpattern.Member is BoundPropertySubpatternMember { Symbol.Kind: SymbolKind.Property or SymbolKind.Field } memberThere was a problem hiding this comment.
That would break for extended property scenario. Will add test to illustrate
|
Test failures look legitimate. |
|
Done review pass (commit 2) |
333fred
approved these changes
Mar 1, 2022
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59804