Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move more package initialization to BG. #60211

Merged
merged 30 commits into from
Mar 28, 2022
Merged

Move more package initialization to BG. #60211

merged 30 commits into from
Mar 28, 2022

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Mar 16, 2022 •
edited by Pilchie
Loading

Fixes AB#1501477

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 16, 2022 21:41
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski PTAL when you have a chance. Thanks!

sharwell
sharwell reviewed Mar 19, 2022
View reviewed changes
src/VisualStudio/Core/Def/Diagnostics/DiagnosticProgressReporter.cs Outdated
var reporter = crawlerService.GetProgressReporter(workspace);
public async Task InitializeAsync(IAsyncServiceProvider serviceProvider)
{
_taskCenterService = await serviceProvider.GetServiceAsync<SVsTaskStatusCenterService, IVsTaskStatusCenterService>().ConfigureAwait(false);
Copy link
Member

@sharwell sharwell Mar 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Make sure this line is not using the GetServiceAsync extension method provided by the VS SDK (it relies on ThreadHelper internally which is incompatible with testing).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AArnott ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that it relies on ThreadHelper. If you're not using the vssdktestfx or something similar to make ThreadHelper work, then ya, this will probably render you code unable to run in your unit tests.

sharwell
sharwell reviewed Mar 19, 2022
View reviewed changes
src/VisualStudio/Core/Def/Implementation/VisualStudioMetadataAsSourceFileSupportService.cs Outdated
Comment on lines 37 to 38
var solution = await serviceProvider.GetServiceAsync<SVsSolution, IVsSolution>().ConfigureAwait(false);
await _threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken);
Copy link
Member

@sharwell sharwell Mar 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Reverse the order of these two lines, and use ConfigureAwait(true) (fewer context switches on average).

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners March 19, 2022 21:28
@CyrusNajmabadi CyrusNajmabadi changed the base branch from main to release/dev17.3 March 21, 2022 03:28
@CyrusNajmabadi CyrusNajmabadi changed the base branch from release/dev17.3 to main March 21, 2022 03:29
@CyrusNajmabadi
Copy link
Member Author

Reverse the order of these two lines, and use ConfigureAwait(true) (fewer context switches on average).

But won't that request the service on the UI thread, which is what we're trying to avoid since it can cause UI-thread mef loads?

jasonmalinowski
jasonmalinowski reviewed Mar 23, 2022
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, but a few odd looking spots.

src/VisualStudio/Core/Def/ProjectSystem/MiscellaneousFilesWorkspace.cs Outdated Show resolved Hide resolved
src/VisualStudio/Core/Def/ProjectSystem/RuleSets/RuleSetEventHandler.cs Outdated Show resolved Hide resolved
src/VisualStudio/Core/Def/RoslynPackage.cs Show resolved Hide resolved
src/VisualStudio/Core/Def/RoslynPackage.cs Outdated Show resolved Hide resolved
...Studio/Core/Def/TableDataSource/Suppression/VisualStudioDiagnosticListTableCommandHandler.cs Show resolved Hide resolved
...Studio/Core/Def/TableDataSource/Suppression/VisualStudioDiagnosticListTableCommandHandler.cs Outdated Show resolved Hide resolved
src/VisualStudio/Core/Def/TableDataSource/Suppression/VisualStudioSuppressionFixService.cs Show resolved Hide resolved
This was referenced Mar 24, 2022
Closed
Closed
@CyrusNajmabadi CyrusNajmabadi merged commit d6bdc4a into dotnet:main Mar 28, 2022
@ghost ghost added this to the Next milestone Mar 28, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the moarBGLoad branch March 28, 2022 22:10
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Mar 29, 2022
Closed
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell left review comments

@AArnott AArnott AArnott left review comments

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.2.P3
Development

Successfully merging this pull request may close these issues.
5 participants
@CyrusNajmabadi @AArnott @jasonmalinowski @sharwell @allisonchou